Add analyzer "Invalid argument null check" (RCS1256)#888
Merged
josefpihrt merged 33 commits intomainfrom Nov 19, 2022
Merged
Conversation
# Conflicts: # src/Analyzers/CSharp/DiagnosticIdentifiers.Generated.cs # src/Analyzers/CSharp/DiagnosticRules.Generated.cs # src/VisualStudioCode/package/src/configurationFiles.generated.ts
# Conflicts: # src/Analyzers/CSharp/Analysis/ValidateArgumentsCorrectlyAnalyzer.cs
# Conflicts: # src/Analyzers.CodeFixes/CSharp/CodeFixes/IfStatementCodeFixProvider.cs # src/Analyzers.CodeFixes/CSharp/CodeFixes/ValidateArgumentsCorrectlyCodeFixProvider.cs # src/Analyzers/CSharp/Analysis/ValidateArgumentsCorrectlyAnalyzer.cs # src/Analyzers/CSharp/DiagnosticIdentifiers.Generated.cs # src/Analyzers/CSharp/DiagnosticRules.Generated.cs # src/Common/ArgumentNullCheckAnalysis.cs
This reverts commit 9139d7d. # Conflicts: # src/Analyzers/Analyzers.xml
josefpihrt
changed the title
josefpihrt
changed the title
Contributor
|
I wish you provided a description so that I could understand the reasoning for this lint, and how to fix the issue. |
Collaborator
Author
|
@BenjaminBrienen Description can be found here: https://github.com/JosefPihrt/Roslynator/blob/main/docs/analyzers/RCS1256.md. I can provide more detailed info if necessary. |
Contributor
|
Yes, please. I had a parameter that was a nullable interface type ( |
Collaborator
Author
|
Could you please create new issue and provide a code sample there? Thanks. |
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.