Merged
Conversation
josefpihrt
requested changes
Jul 25, 2023
Co-authored-by: Josef Pihrt <josef@pihrt.net>
josefpihrt
approved these changes
Jul 26, 2023
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
Co-authored-by: Josef Pihrt <josef@pihrt.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the field is explicitly defined this can cause implicit casting on assignment. In these cases explicitly returning rather than assigning (as RCS1179 suggests) would change the return type of the function (leading to the code not compiling) - see test code for examples.
This PR adds a check to prevent the diagnostic from being suggested if the return type doesn't exactly match the explicit type of the variable.