Merged
Conversation
josefpihrt
requested changes
Jun 6, 2023
Collaborator
josefpihrt
left a comment
There was a problem hiding this comment.
If you want to simplify the code even more, the method
private static void AnalyzeMemberDeclaration(SyntaxNodeAnalysisContext context)
can include all type declarations and member declarations. Virtually all cases except UnsafeStatement and LocalFunctionStatement.
src/Analyzers/CSharp/Analysis/UnnecessaryUnsafeContextAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Analysis/UnnecessaryUnsafeContextAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Tests/Analyzers.Tests/RCS1216UnnecessaryUnsafeContextTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Analyzers.Tests/RCS1216UnnecessaryUnsafeContextTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Analyzers.Tests/RCS1216UnnecessaryUnsafeContextTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Analyzers.Tests/RCS1216UnnecessaryUnsafeContextTests.cs
Outdated
Show resolved
Hide resolved
src/Tests/Analyzers.Tests/RCS1216UnnecessaryUnsafeContextTests.cs
Outdated
Show resolved
Hide resolved
josefpihrt
requested changes
Jun 9, 2023
src/Tests/Analyzers.Tests/RCS1216UnnecessaryUnsafeContextTests.cs
Outdated
Show resolved
Hide resolved
josefpihrt
approved these changes
Jun 22, 2023
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
Co-authored-by: Josef Pihrt <josef.pihrt@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if an unsafe local block is located inside a for statement then one of the asserts will fail https://github.com/JosefPihrt/Roslynator/blob/1d035ba7b32fafd9057e3c02f3a903a1493ae212/src/Analyzers/CSharp/Analysis/UnnecessaryUnsafeContextAnalyzer.cs#L248
For example
To fix this and make the code easier to grok I refactored the 3 distinct methods of walking up the syntax tree checking for unsafe modifiers into a single loop. I also Added a new test suite for the analyzer/code fix of RCS1216 as one currently does not exist.