[BUG] Currently pressed key is not removed if shift is released first

[damusnet]

Describe the bug
The order in which combo keys are released matters, when it should not.

To Reproduce

1. Setup a shift+? hotkey
2. Press shift, press ?, release shift first, release ? second
3. Press shift again
4. Hotkey triggers, even though ? is not pressed

CodeSanbdox Repro

Expected behavior
Hotkey should not trigger again on shift only, since ? is not pressed anymore

Screenshots

[damusnet]

After a bit of investigation, this sort of makes sense. When pressing combo keys, the following is (roughly) registered:

• Add shift
• Add ?
• Remove shift
• Remove / <= that's the issue ; it's because without the shift, the ? key is now registered as a / key. So ? is never removed from the currently pressed keys, and any press to shift triggers the combo again.

This is on a en-US keyboard, but I suspect it's true for any shift combo on any keyboard. The particular key here is:

┌─────┐
│  ?  │
│  /  │
└─────┘

Not sure how best to fix this, as I don't fully understand the entire implementation logic.

Incidentally, pressing / then shift, which should (could?) produce the shift+?, does not work either.

[tamerxkilinc]

I solved this by doing the same as for the command key. On macOS the keyup event of letters and digits is not triggering while holding the command key down. That's why you can't just remove single keys of the array but need to clear it. The way I solved this also worked for the shift key!

Set a timeout each time shift is pressed. When it is released, instead of trying to remove the specific characters which were pressed with the shift key, the array of pressed keys is cleared completely. This ensures that you have no characters left in the pressed keys array.

[JohannesKlauss]

Yes this is currently a problem, because the library mixes the produces symbol with the produced key code. This will be fixed in version 5.

[JohannesKlauss]

This is a layout specific problem that gets addressed in version 5.

This has been fixed in pre release 5.0.0-1. Please try out this version.
To listen to = use you just use useHotkeys('=', callback, {useKey: true})

Please let me know if that fixes your issue.

[TomPridham]

It seems like the property should prolly be useCode: true, right? For things like ., the key changes when shift is pressed, but the code stays the same

[TomPridham]

I'd be happy to update your changes from the 5.0.0-1 branch if that sounds right to you