Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The NPC isn't configured to use skin overlays #168

Open
squili opened this issue Jun 26, 2021 · 2 comments
Open

The NPC isn't configured to use skin overlays #168

squili opened this issue Jun 26, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@squili
Copy link
Contributor

squili commented Jun 26, 2021

When sending out the entity metadata for the NPC, the skin overlay isn't set. This means that things like hats don't render on the NPCs. This can be fixed by adding a byte with value 0x7F and index 17 to the metadata packet.
See: packet metadata

@squili squili added the bug Something isn't working label Jun 26, 2021
@keksgauner
Copy link

keksgauner commented Jul 29, 2021

I didn't know anything about this.
Did you mean something like this?

LivingEntity le = (LivingEntity) npc;
le.getMetadata("0x4D").get(17);

I think I need to read about this

@squili
Copy link
Contributor Author

squili commented Jul 29, 2021

I'm not exactly sure what NMS code you'd use for this. I wasn't able to get any NMS changes in the library to work on my test server, so I wasn't able to make a PR for this. All I know is that, according to the wiki.vg docs, that's what you need to add to get it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants