Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aur): only check gpg signature after gpg import . fixes #2165 #2239

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

Jguer
Copy link
Owner

@Jguer Jguer commented Jul 6, 2023

only check gpg signature after gpg import

fixes #2165

@Jguer
Copy link
Owner Author

Jguer commented Jul 6, 2023

@jdholtz & @smolx, yay works even when removing downloadPKGBUILDSourceFanout (preparer.go:229), it would just lose concurrent downloading of pkgbuild sources and sources wouldn't be available for pre install hooks if they were to be added.

What's your opinion on PKGBUILD source downloading before install? Do you find the concurrency useful?

@jdholtz
Copy link
Contributor

jdholtz commented Jul 6, 2023

What's your opinion on PKGBUILD source downloading before install? Do you find the concurrency useful?

I definitely see it being useful as it can significantly speed up the total time spent downloading large AUR packages, especially during a full system upgrade. Are there any other disadvantages to removing this functionality besides the need to maintain it?

@smolx
Copy link
Contributor

smolx commented Jul 6, 2023

I don't have a strong opinion on this matter. Personally I rarely see more than 2-3 parallel downloads, so I can't really feel the effect. But definitely there are users with high speed internet connection who use AUR more extensively. They feel the maximum effect.
I also think that downloading of multiple targets in parallel is de facto standard now. Perhaps better to have it than not to have.

@Jguer Jguer merged commit 23b053b into next Jul 10, 2023
@Jguer Jguer deleted the jguer/fix-2165 branch July 10, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yay imports new PGP key after failed signature check
3 participants