Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't respect graphql-config possible places? #47

Closed
Anahkiasen opened this issue Dec 10, 2016 · 4 comments
Closed

Doesn't respect graphql-config possible places? #47

Anahkiasen opened this issue Dec 10, 2016 · 4 comments
Labels

Comments

@Anahkiasen
Copy link

The graphql-config says this plugin is compliant to it. But it seems it only works when in a graphql.config.json file, and that the plugin does not look for a .graphqlrc nor inside the package.json. Is my assumption correct?

@jimkyndemeyer
Copy link
Collaborator

Hi Maxime.

Thanks for using the plugin.

It's not easy to spot, but support is listed as "(pending)" on the graphql-config page. In other words, no this plugin doesn't support graphql-config at this time.

The bottom line is that agreeing on a shared format that makes sense in all the various GraphQL enviroments is complicated. A few examples of the ongoing discussions:
kamilkisiela/graphql-config#9 and facebook/create-react-app#462 and #31.

So there's various technical constraints and feature requests at play. Not to mention migration paths between the different config file formats.

Let me know if you have any questions.

/Jim

/cc @schickling

@schickling
Copy link

Thanks for looping me in @jimkyndemeyer. I'd be happy to push this forward over the coming weeks. I'll reach out to you to discuss next steps.

@jimkyndemeyer
Copy link
Collaborator

@schickling sure. Wanted to keep you posted.

Although, between designing a new house and https://github.com/jimkyndemeyer/js-graphql-language-service/issues/11 I doubt that I can find the time to move this forward any time soon.

Let's talk further down the line.

/Jim

@jimkyndemeyer
Copy link
Collaborator

Closing this in favor of kamilkisiela/graphql-config#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants