Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Inline Markdown Documentation #185

Closed
bericp1 opened this issue Nov 7, 2018 · 9 comments
Closed

Support Inline Markdown Documentation #185

bericp1 opened this issue Nov 7, 2018 · 9 comments

Comments

@bericp1
Copy link

bericp1 commented Nov 7, 2018

Version and Environment Details

Operation system: macOS High Sierra 10.13.5

IDE name and version: WebStorm 2018.2.5

Plugin version: 1.7.2

Expected Behaviour

Inline markdown comments with double quotes (single-line) and triple double quotes (multi-line) which apollo-server at least supports as a means of documenting the scheme are syntax highlighted and maybe interpreted by the plugin.

Actual Behaviour

Inline markdown comments are considered an error:

Error:(5, 3) Syntax Error GraphQL (5:3) Unexpected String

Screenshot of error: Error:(5, 3) Syntax Error GraphQL (5:3) Unexpected String

And syntax highlighted as errors:

Screenshot of syntax highlighted

Steps to Reproduce / Link to Repo with Reproduction and Instructions

  1. Create a JS file in an apollo-server project
  2. Import the gql template template tag from apollo-server
  3. Create a template literal, tag it with gql, and fill it with a valid GraphQL type using the standard GraphQL Schema Language
  4. Add a single- or multi-line comment to the type per the documentation here.
@jimkyndemeyer
Copy link
Collaborator

Hi Brandon.

Thanks for using the plugin.

Documentation in quotes/tripe quotes was a breaking language change that was added to the GraphQL spec after the V1.x parser and language service for this plugin was built. V1 expects documentation to be in # line comments above types and fields.

V2 of this plugin follows that newer language spec, but is still work in progress. Currently V2 shows documentation in completions, but the quick documentation viewer found in V1 is yet to be built.

You can read more about V2 in #164 and https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/releases and try it out if you prefer to use quotes for the documentation.

I'll keep this issue around as markdown support would be a nice addition to V2.

Best regards,
Jim.

@nanandn
Copy link

nanandn commented Dec 20, 2018

How do I install the v2 version of this plugin?

@jimkyndemeyer
Copy link
Collaborator

Hi @nanandn

The installation steps for v2 are included in the releases under the "Getting and installing the alpha releases" section. See https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/releases/tag/2.0.0-alpha-3 for the latest release.

Best regards,
Jim

@nanandn
Copy link

nanandn commented Dec 21, 2018

@jimkyndemeyer Thanks. Installed the update.

@nanandn
Copy link

nanandn commented Dec 21, 2018

@jimkyndemeyer A couple of things after the update...

  1. Syntax highlighting not working in graphqls files.
  2. In the old version there was a refresh/restart button in the graphql tool window which would load the schema again. The new version does not have that. Is that a bug?
  3. In the new version, I see errors - "No type information available due to schema errors."

@jimkyndemeyer
Copy link
Collaborator

jimkyndemeyer commented Dec 21, 2018

@nanandn Please read through the documentation on schema discovery in the release link I posted earlier for you. Version 2 uses a completely different and more flexible approach.

Regarding .graphqls files, that's included for backwards compatibility in the next alpha, but the official file extension is .graphql. If you need to use graphqls files now you can associate them with the GraphQL format using the "Editor -> File types" settings in your IDE.

For furture reference please add your feedback to #164 I'll remove the comments here later as they don't belong in this issue.

@nanandn
Copy link

nanandn commented Dec 21, 2018

@jimkyndemeyer Sorry. I realized the documentation mentions the new approach after I added my comment. Reading the doc now.

@jimkyndemeyer
Copy link
Collaborator

Just released https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/releases/tag/2.0.0-alpha-4 with support for markdown in documentation.

Best regards,
Jim.

@jimkyndemeyer
Copy link
Collaborator

Closing this as markdown documentation has been supported since 2.0.0-alpha-4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants