-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hijri Date #8
Comments
Hey, it will be more useful if you can provide some screenshots with the steps you have done so i/we can reproduce the issue, for example: where the issue happens exactly? in which month? ..
well, we need to investigate first about the reason of the issue, then we may take a decision about how to fix it x). Finally, you're welcome. |
like for example today date is wrong, its 26/03/1440 but in the SIlaty software its past a day (25/03) you can check that. |
to explain more,
and thanks a lot for what you did, this app helped me a lot. |
Inshalah x). Also, i'm okay with the second solution because it seems more easy to implement, i guess. There is also a fast solution by modifying the value in the line below to Line 54 in 8df0ce1
unfortunately this value seems to be constant so i'll keep thinking about how to implement the +/-1 day option.. |
or don't worry, I will do it soon when I got some time : ) , and make a pull request |
fixed on 4f7f462 You can test it using my fork https://github.com/AXeL-dev/Silaty P.S.: the debian package is not yet updated so you may need to Install it from source. |
I have rarely coded in python, so that's why I can't help you right now in codes.
The problem here goes in the Hijri date, even with that Algorithm it sometimes goes wrong for example by one day missing.
I think adding the option for that day in the options menu will help a lot.
Thanks for your work, I really like the app, and I will soon Inshaa Allah help you improving it.
Omar E.
The text was updated successfully, but these errors were encountered: