Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect only works as intended on certain image sizes #4

Open
Jesper-Hustad opened this issue Sep 19, 2022 · 0 comments
Open

Effect only works as intended on certain image sizes #4

Jesper-Hustad opened this issue Sep 19, 2022 · 0 comments
Labels
bug Something isn't working hacktoberfest

Comments

@Jesper-Hustad
Copy link
Owner

Jesper-Hustad commented Sep 19, 2022

Currently the wave distort effect has a hard coded distort amount per pixel.
This works well for simple screenshots of designs.

A common use case is saving pages as high resolution images.
The hardcoded effect will therefore be hardly noticeable in those circumstances.

Solution: make the effect scale depending on resolution

The filter where this code is located is called effectDistortWave in filters.js

@Jesper-Hustad Jesper-Hustad added the bug Something isn't working label Sep 19, 2022
@Jesper-Hustad Jesper-Hustad changed the title Effect only works well on certain image sizes Effect only works as intended on certain image sizes Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant