-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 401 and 403 error messages for put saver #5638
Add 401 and 403 error messages for put saver #5638
Conversation
FYI @pmario @Jermolene . This will make the put saver more user friendly for TiddlyHost. |
See also tiddlyhost/tiddlyhost-com#148 . |
3f5b06f
to
a24cfe4
Compare
Hi @simonbaird that looks great. You don't need to worry about the translations; the translators tool picks up core strings that haven't been translated into a particular language. |
The message could perhaps be more verbose, e.g.:
|
I also considered moving the messages to PutError/* instead of Error/* which would make sense if they were going to be specific to put saving. |
Ack, will push a revision soon without the translations |
d161032
to
6720fc6
Compare
Show the user a more useful message for the case where they're not correctly authenticated and try to do a "put" save. The context for this change is that I'm thinking about using the put saver for TiddlyHost instead of the old upload saver, but it should be generally useful. Also includes a name change for the one existing error message. I want to indicate these three messages are related, so I added the "Put" prefix to make them appear next to each other in the language files. (The Error/EditConflict string is used in just this one place as far as I can tell.)
6720fc6
to
7f19231
Compare
Moving out of draft mode. There's a few changes since the original. Let me know if you don't like it. |
Thanks @simonbaird, great stuff. |
Awesome, thanks @Jermolene . |
Show the user a more useful message for the case where they're not
correctly authenticated and try to do a "put" save.
The context for this change is that I'm thinking about using the
put saver for TiddlyHost instead of the old upload saver, but it
should be generally useful.
Also includes a name change for the one existing error message. I
want to indicate these three messages are related, so I added the
"Put" prefix to make them appear next to each other in the language
files. (The Error/EditConflict string is used in just this one place
as far as I can tell.)