Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the IMail interface #387

Closed
Jericho opened this issue Apr 28, 2021 · 1 comment
Closed

Simplify the IMail interface #387

Jericho opened this issue Apr 28, 2021 · 1 comment
Assignees
Labels
Breaking Change This change causes backward compatibility issue(s)
Milestone

Comments

@Jericho
Copy link
Owner

Jericho commented Apr 28, 2021

Several methods currently on the IMail interface are what I call "convenience" methods: they address common scenarios like sending the same email to multiple recipients, sending a single email without using a template, sending a single email using a legacy template, sending a single email using a dynamic template, etc. and behind the scene they simply invoke the IMail.SendAsync method with the appropriate parameters for the given scenario.

These methods should be implemented as extension methods and only the SendAsync method should be on the IMail interface.

@Jericho Jericho added the Breaking Change This change causes backward compatibility issue(s) label Apr 28, 2021
@Jericho Jericho added this to the 0.80.0 milestone Apr 28, 2021
@Jericho Jericho self-assigned this Apr 28, 2021
@Jericho Jericho closed this as completed in 60f466c May 4, 2021
@Jericho
Copy link
Owner Author

Jericho commented May 5, 2021

🎉 This issue has been resolved in version 0.80.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change This change causes backward compatibility issue(s)
Projects
None yet
Development

No branches or pull requests

1 participant