Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to Lockfree checkqueue PR #1

Closed
wants to merge 11 commits into from
Closed

Tweaks to Lockfree checkqueue PR #1

wants to merge 11 commits into from

Commits on Mar 29, 2017

  1. Relax memory_order semantics in checkqueue

    @JeremyRubin
    JeremyRubin committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    80a8c18 View commit details
    Browse the repository at this point in the history

  2. No longer call destructors on tasks in checkqueue -- task itself shou… 

    …ld be in charge of cleaning up any resources that should be
    @JeremyRubin
    JeremyRubin committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    07e30da View commit details
    Browse the repository at this point in the history

  3. Cleanup confusing fOk loop state variable in checkqueue.h

    @JeremyRubin
    JeremyRubin committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    ec1e706 View commit details
    Browse the repository at this point in the history

  4. relax read of fMasterPresent in checkqueue.h

    @JeremyRubin
    JeremyRubin committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    2c311d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2017

  1. Refactor CheckQueue for clarity. Only check top_cache when cache is o… 

    …ut of work
    @JeremyRubin
    JeremyRubin committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    b276d7a View commit details
    Browse the repository at this point in the history

  2. Signal in CheckQueue when no more checks will be added using the top … 

    …bit of top_cache
    @JeremyRubin
    JeremyRubin committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    aa21c91 View commit details
    Browse the repository at this point in the history

  3. Change fAllOk in checkqueue into a test_flag, removing one atomic acc… 

    …ess in hot path
    @JeremyRubin
    JeremyRubin committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    3b3da89 View commit details
    Browse the repository at this point in the history

  4. Tweak checkqueue so that fMasterPresent is not read unless all work h… 

    …as been completed OR there is no work
    @JeremyRubin
    JeremyRubin committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    cbde4e5 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2017

  1. Get rid of fMasterPresent variable in checkqueue

    @JeremyRubin
    JeremyRubin committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    d152289 View commit details
    Browse the repository at this point in the history

  2. Get rid of boost::{thread, mutex, condition_variable} from CheckQueue… 

    …, and make the checkqueue own it's worker threads
    @JeremyRubin
    JeremyRubin committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    15d2796 View commit details
    Browse the repository at this point in the history

  3. Fix the tests using CCheckQueue (and benchmarks) that broke with the new 

    threading model.
    @JeremyRubin
    JeremyRubin committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    aa84743 View commit details
    Browse the repository at this point in the history