Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test full feature separately on CI #424

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

tyranron
Copy link
Collaborator

@tyranron tyranron commented Nov 6, 2024

Resolves #420

Synopsis

cargo test --no-default-features --features=full fails imposing problems on other CIs.

See #420 for more context.

Solution

  • Consider testing full Cargo feature in test-features CI job to handle such regressions.
  • Update the relevant tests to run under no_std too.

Checklist

  • Documentation is updated (not required)
  • Tests are added/updated
  • CHANGELOG entry is added (not required)

@tyranron tyranron added this to the 2.0.0 milestone Nov 6, 2024
@tyranron tyranron self-assigned this Nov 6, 2024
@tyranron tyranron marked this pull request as ready for review November 6, 2024 16:33
@tyranron tyranron requested a review from JelteF November 6, 2024 16:33
@tyranron tyranron enabled auto-merge (squash) November 6, 2024 16:37
@tyranron
Copy link
Collaborator Author

ping @JelteF

2 similar comments
@tyranron
Copy link
Collaborator Author

ping @JelteF

@tyranron
Copy link
Collaborator Author

ping @JelteF

@tyranron tyranron merged commit 6844e63 into master Nov 28, 2024
17 checks passed
@tyranron tyranron deleted the 420-fix-full-feature-nostd-tests branch November 28, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo test --no-default-features --features=full fails because of no_std
2 participants