Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.9 delete icon visible to guests and member without edit rights #54

Closed
HerzScheisse opened this issue Feb 17, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@HerzScheisse
Copy link
Contributor

Hi Jefferson49,

I fear that you can read my thoughts :D
while playing and using your module really often, a while ago i thought it would be cool if we have a delete button for sources... and now you braught this to life... Thank you...

anyway.. while updating the module, i noticed that the delete icon is visible to guests and also to members which dont have editor rights... I also can click on that icon an the page gets refreshed.. but the source is not deleted, and also dont got a error message...

Is it just me or do you also have this icon visible? I checked your family page but dont see the icon.. but i also dont know if you have the latest update installed...

2024-02-17 17_57_56-Window

Kind regards,
Holger

@Jefferson49
Copy link
Owner

Hallo Holger,

thank you for reporting the issue!

Indeed, this is wrong. For copy/paste of sources, I added a check if the logged in user has the rights to edit the fact. Unfortunatelly, I forgot to add the same check for the delete and move icons.

I have already tested a bugfix.

Grüße

Markus

@Jefferson49 Jefferson49 added the bug Something isn't working label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants