Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards supporting Unitful axes #10

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Towards supporting Unitful axes #10

merged 3 commits into from
Jun 16, 2021

Conversation

JeffFessler
Copy link
Owner

Work-around to avoid this issue:
PainterQubits/Unitful.jl#455

I was hoping to nicely support units on the x,y axes.
This PR at least keeps them from causing errors.

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #10 (e33ca67) into main (75fae1c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           92        93    +1     
=========================================
+ Hits            92        93    +1     
Impacted Files Coverage Δ
src/jim.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75fae1c...e33ca67. Read the comment docs.

@JeffFessler JeffFessler merged commit 8b66c4b into main Jun 16, 2021
@JeffFessler JeffFessler deleted the unit branch June 16, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant