Update documentation#305
Merged
Merged
Conversation
Contributor
|
Great stuff @tim-cools - I was about to get started on these, good thing I stalled 😉 |
Contributor
Author
|
@nieve yeah, docs are not the most fun todo, so better to divide the work a bit :-) |
Member
|
Not much fun, but very much appreciated |
2 tasks
jeremydmiller
added a commit
that referenced
this pull request
May 19, 2026
#4483) JasperFx PR #306 ("Wrap per-event in SG DetermineActionAsync overrides, closes #305") shipped in the new wave: - JasperFx 2.0.0-alpha.14 → 2.0.0-alpha.15 - JasperFx.Events 2.0.0-alpha.13 → 2.0.0-alpha.14 - JasperFx.Events.SourceGenerator 2.0.0-alpha.6 → 2.0.0-alpha.7 - JasperFx.RuntimeCompiler 5.0.0-alpha.2 → 5.0.0-alpha.3 - JasperFx.SourceGeneration 2.0.0-alpha.2 → 2.0.0-alpha.4 #305 was the regression I filed yesterday in #4482: PR #304's per-event ApplyEventException wrapping was correct inside JasperFxAggregationProjectionBase but the SG-emitted DetermineActionAsync overrides weren't covered, so raw InvalidOperationException still surfaced through the AggregateException AggregationRunner.BuildBatchAsync throws, and GroupedProjectionExecution.buildBatchWithSkipping's OfType<ApplyEventException>() filter emptied out. PR #306 wraps each per-event call inside the SG's DetermineActionAsync override emission, restoring the seam end-to-end. Verified locally with DISABLE_TEST_PARALLELIZATION=true (CI default): all 4 tests in rebuilds_with_serialization_or_poison_pill_events pass on both net9.0 and net10.0, including both Theory inline cases (*DEFAULT*, CustomTenant) of rebuild_the_projection_skip_failed_events. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#278