Add TypeScript declarations for typing #62
Conversation
|
👍 thanks man |
|
Thanks a lot @aaronbroad, just an update as it's been a while. I started a branch locally to switch this project over to TypeScript and have been referencing this PR while doing it. 1. It means the generated declarations file should always be up to date and 2. personally, it's a good way for me to try out and learn TS. I've not had time since then to work on any of my open source projects but this is high up the list when I do get time again. Thanks. |
|
Hey, One thing I'm wondering is, should |
|
I don't think you need to reference jasmine's typings. If you want, we could include jasmine's types in the package.json file (I don't believe jasmine includes typing definitions in its npm package yet.) |
|
For people checking in here, I can't move this forward as I don't know TypeScript well enough to understand the typings files and how they relate to upstream projects like jasmine. I'm open to converting this codebase to TypeScript, but there are other things higher up my to-learn list unfortunately – so this step may take a little time unless someone is willing to contribute and help in a hand-over. Thanks all. |
|
@JamieMason but can you merge pull requests for TypeScript typings so we're unblocked? |
|
sure, give me 10-15 mins |
|
This has been merged as 105bcc3. I've a better grasp of TypeScript now so will be able to maintain this from here. Thanks a lot, and sorry for such a long wait. |
Currently, there's a mismatch with `@types/jasmine` that throws the following error: ``` node_modules/@types/jasmine/index.d.ts(404,15): error TS2428: All declarations of 'Matchers' must have identical type parameters. node_modules/jasmine-expect/jasmine-matchers.d.ts(2,13): error TS2428: All declarations of 'Matchers' must have identical type parameters. ``` this adjustment fix the Typescript definitions of the project. Refs JamieMason#62
to resolve #59