JsonConvert.DeserializeObject<Stack<T>>/JsonConvert.Serialize(Stack<T) does not work as expected.

[rymeskar]

When I serialize a Stack of strings, or of anything else for that matter, and then try to deserialize it with the functions mentioned in the headline, I get a stack with reversed order. Is this unexpected behavior an intended feature? Then to get the expected behavior, I would have to write a specific code for handling stack?

Code that revealed this "feature":

var stack = new Stack<string>();
stack.Push("Inserted first, should be popped last");
stack.Push("Inserted last, should be popped first");
var serializedStack = JsonConvert.SerializeObject(stack);
Console.WriteLine(serializedStack);
//["Inserted last, should be popped first","Inserted first, should be popped last"]
stack = JsonConvert.DeserializeObject<Stack<string>>(serializedStack);
serializedStack = JsonConvert.SerializeObject(stack);
Console.WriteLine(serializedStack);
//["Inserted first, should be popped last","Inserted last, should be popped first"]
Console.WriteLine(stack.Pop());
//Inserted first, should be popped last
Console.WriteLine(stack.Pop());
//Inserted last, should be popped first

[JamesNK]

I'm afraid this is a limition of a Stack. The results returned when it is serialized and the opposite order for when it is deserialized.

[SlimeQ]

How could this possibly be a limitation of the stack? The library should just convert to a list and reverse it before serializing. Or when deserializing, deserialize first to a list, reverse it, and create a stack from that list

[SlimeQ]

            HistoryManager.instance.undoStack = new Stack<HistoryItem>(undoStack.Reverse());
            HistoryManager.instance.redoStack = new Stack<HistoryItem>(redoStack.Reverse());

See? Easy as pie.

Don't blame the built-in types, deal with them!

EDIT: Actually the Stack constructor reverses the input stack, so .Reverse() is unnecessary.

[Banyc]

This issue has not been fixed even in version 12.0.3. Sad.