When contributing to this repository, please first discuss the change you wish to make via issue, email, or any other method with the owners of this repository before making a change.
- Ensure that you've tested your feature/change yourself. You can reference the forked action in your own workflow by using your GitHub username, for example
yourname/fetch-api-data-action@master
. - Ensure your change passes all of the integration tests.
- Make sure you update the README if you've made a change that requires documentation.
- When making a pull request, highlight any areas that may cause a breaking change so the maintainer can update the version number accordingly on the GitHub marketplace and package registries.
- Make sure you've linted and formatted your code. You can do this by running
yarn lint
andyarn lint:format
. - Fix or add any tests where applicable. You can run
yarn test
to run the suite. As this action is small in scope it's important that a high level of test coverage is maintained. All tests are written using Jest. - As this package is written in TypeScript please ensure all typing is accurate and the action compiles correctly by running
yarn build
.
In order to deploy and test your own fork of this action, you must commit the node_modules
dependencies. Be sure to run nvm use
before installing any dependencies. You can learn more about nvm here.
To do this you can follow the instructions below:
Install the project:
yarn install
Comment out the following in distribution branches:
# node_modules/
Build the project:
yarn build
Commit:
$ git checkout -b branchnamehere
$ git commit -a -m "prod dependencies"
The node_modules
folder should not be included when making a pull request. These are only required for GitHub Actions when it consumes the distribution branch, the dev
branch of the project should be free from any dependencies or lib files.