fix(uiux): remove fading edge on horizontal scrollviews

Author: jagandeepbrar

lib/main.dart

@@ -81,7 +81,6 @@ class LunaBIOS extends StatelessWidget {
                 supportedLocales: context.supportedLocales,
                 locale: context.locale,
                 builder: DevicePreview.appBuilder,
-                useInheritedMediaQuery: true,
                 darkTheme: theme.activeTheme(),
                 theme: theme.activeTheme(),
                 title: 'LunaSea',

lib/modules/lidarr/routes/catalogue.dart

@@ -30,7 +30,11 @@ class _State extends State<LidarrCatalogue>
   Future<void> loadCallback() async {
     if (mounted) setState(() => _results = []);
     final _api = LidarrAPI.from(LunaProfile.current);
-    if (mounted) setState(() => {_future = _api.getAllArtists()});
+    if (mounted) {
+      setState(() {
+        _future = _api.getAllArtists();
+      });
+    }
   }
 
   void _refreshState() => setState(() {});

lib/modules/lidarr/routes/edit_artist.dart

@@ -46,7 +46,11 @@ class _State extends State<ArtistEditRoute> with LunaScrollControllerMixin {
         bottomNavigationBar: _bottomActionBar(),
       );
 
-  Future<void> _refresh() async => setState(() => {_future = _fetch()});
+  Future<void> _refresh() async {
+    setState(() {
+      _future = _fetch();
+    });
+  }
 
   Future<bool> _fetch() async {
     final _api = LidarrAPI.from(LunaProfile.current);

lib/modules/lidarr/routes/search_results.dart

@@ -27,7 +27,9 @@ class _State extends State<ArtistAlbumReleasesRoute>
   Future<void> loadCallback() async {
     if (mounted) setState(() => _results = []);
     final _api = LidarrAPI.from(LunaProfile.current);
-    setState(() => {_future = _api.getReleases(widget.albumId)});
+    setState(() {
+      _future = _api.getReleases(widget.albumId);
+    });
     //Clear the search filter using a microtask
     Future.microtask(
         () => context.read<LidarrState>().searchReleasesFilter = '');

lib/modules/nzbget/routes/statistics.dart

@@ -40,11 +40,15 @@ class _State extends State<StatisticsRoute> with LunaScrollControllerMixin {
   }
 
   Future<void> _fetchStatistics(NZBGetAPI api) async {
-    return await api.getStatistics().then((stats) => {_statistics = stats});
+    return await api.getStatistics().then((stats) {
+      _statistics = stats;
+    });
   }
 
   Future<void> _fetchLogs(NZBGetAPI api) async {
-    return await api.getLogs().then((logs) => {_logs = logs});
+    return await api.getLogs().then((logs) {
+      _logs = logs;
+    });
   }
 
   @override

lib/modules/sonarr/routes/upcoming/route.dart

@@ -100,13 +100,13 @@ class _State extends State<SonarrUpcomingRoute>
     List<List<Widget>> _episodeWidgets = [];
     _episodeMap.keys.toList()
       ..sort()
-      ..forEach((key) => {
-            _episodeWidgets.add(_buildDay(
-              (_episodeMap[key]!['date'] as String?),
-              (_episodeMap[key]!['entries'] as List).cast<SonarrCalendar>(),
-              series,
-            )),
-          });
+      ..forEach((key) {
+        _episodeWidgets.add(_buildDay(
+          (_episodeMap[key]!['date'] as String?),
+          (_episodeMap[key]!['entries'] as List).cast<SonarrCalendar>(),
+          series,
+        ));
+      });
     // Return the list
     return LunaListView(
       controller: SonarrNavigationBar.scrollControllers[1],

lib/vendor.dart

@@ -7,7 +7,6 @@ export 'dart:typed_data';
 export 'package:dio/dio.dart';
 export 'package:easy_localization/easy_localization.dart';
 export 'package:expandable/expandable.dart';
-export 'package:fading_edge_scrollview/fading_edge_scrollview.dart';
 export 'package:flash/flash.dart';
 export 'package:flutter_riverpod/flutter_riverpod.dart';
 export 'package:go_router/go_router.dart';

lib/widgets/ui/appbar.dart

@@ -282,14 +282,11 @@ class _State extends State<LunaAppBar> {
           mainAxisSize: MainAxisSize.min,
           children: [
             Flexible(
-              child: FadingEdgeScrollView.fromSingleChildScrollView(
-                child: SingleChildScrollView(
-                  controller: ScrollController(),
-                  scrollDirection: Axis.horizontal,
-                  child: Text(
-                    widget.title!,
-                    style: const TextStyle(fontSize: LunaUI.FONT_SIZE_H1),
-                  ),
+              child: SingleChildScrollView(
+                scrollDirection: Axis.horizontal,
+                child: Text(
+                  widget.title!,
+                  style: const TextStyle(fontSize: LunaUI.FONT_SIZE_H1),
                 ),
               ),
             ),

lib/widgets/ui/block/block.dart

@@ -388,12 +388,9 @@ class LunaBlock extends StatelessWidget {
     required Widget child,
     Axis scrollDirection = Axis.horizontal,
   }) {
-    return FadingEdgeScrollView.fromSingleChildScrollView(
-      child: SingleChildScrollView(
-        controller: ScrollController(),
-        scrollDirection: scrollDirection,
-        child: child,
-      ),
+    return SingleChildScrollView(
+      scrollDirection: scrollDirection,
+      child: child,
     );
   }
 }

lib/widgets/ui/block/grid_block.dart

@@ -138,22 +138,19 @@ class LunaGridBlock extends StatelessWidget {
   Widget _title() {
     return Container(
       child: Padding(
-        child: FadingEdgeScrollView.fromSingleChildScrollView(
-          child: SingleChildScrollView(
-            controller: ScrollController(),
-            scrollDirection: Axis.horizontal,
-            child: RichText(
-              text: TextSpan(
-                style: const TextStyle(
-                  fontSize: LunaUI.FONT_SIZE_H3,
-                  color: LunaColours.white,
-                  fontWeight: LunaUI.FONT_WEIGHT_BOLD,
-                ),
-                text: title,
+        child: SingleChildScrollView(
+          scrollDirection: Axis.horizontal,
+          child: RichText(
+            text: TextSpan(
+              style: const TextStyle(
+                fontSize: LunaUI.FONT_SIZE_H3,
+                color: LunaColours.white,
+                fontWeight: LunaUI.FONT_WEIGHT_BOLD,
               ),
-              overflow: TextOverflow.visible,
-              softWrap: false,
+              text: title,
             ),
+            overflow: TextOverflow.visible,
+            softWrap: false,
           ),
         ),
         padding: LunaUI.MARGIN_DEFAULT_HORIZONTAL,
@@ -166,21 +163,19 @@ class LunaGridBlock extends StatelessWidget {
   Widget _subtitle() {
     return Container(
       child: Padding(
-        child: FadingEdgeScrollView.fromSingleChildScrollView(
-          child: SingleChildScrollView(
-            controller: ScrollController(),
-            scrollDirection: Axis.horizontal,
-            child: RichText(
-              text: TextSpan(
-                style: const TextStyle(
-                  fontSize: LunaUI.FONT_SIZE_H3,
-                  color: LunaColours.grey,
-                ),
-                children: [subtitle],
+        child: SingleChildScrollView(
+          controller: ScrollController(),
+          scrollDirection: Axis.horizontal,
+          child: RichText(
+            text: TextSpan(
+              style: const TextStyle(
+                fontSize: LunaUI.FONT_SIZE_H3,
+                color: LunaColours.grey,
               ),
-              overflow: TextOverflow.visible,
-              softWrap: false,
+              children: [subtitle],
             ),
+            overflow: TextOverflow.visible,
+            softWrap: false,
           ),
         ),
         padding: LunaUI.MARGIN_DEFAULT_HORIZONTAL,

pubspec.lock

@@ -369,14 +369,6 @@ packages:
       url: "https://pub.dev"
     source: hosted
     version: "5.0.1"
-  fading_edge_scrollview:
-    dependency: "direct main"
-    description:
-      name: fading_edge_scrollview
-      sha256: c25c2231652ce774cc31824d0112f11f653881f43d7f5302c05af11942052031
-      url: "https://pub.dev"
-    source: hosted
-    version: "3.0.0"
   fake_async:
     dependency: transitive
     description:

pubspec.yaml

@@ -20,7 +20,6 @@ dependencies:
   email_validator: ^2.1.17
   encrypt: ^5.0.1
   expandable: ^5.0.1
-  fading_edge_scrollview: ^3.0.0
   file_picker: ^5.2.6
   firebase_auth: ^4.3.0
   firebase_core: ^2.8.0