Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Nov 16, 2025

Follow-up to #14271

I see that we need a @Command for jabkit, but also a "wrapper" around to initialiize. Currently, the class name is not consistent to the command - this fixes it.

  • entry point: JabKitLauncher
  • command "jabkit": JabKit

Also cleans up packages - removes cli; our toolkit is already the CLI.

Steps to test

  • Run JabKit Launcher
  • jbang .jbang/JabKitLauncher

Mandatory checks

- entry point: JabKitLauncher
- command "jabkit": JabKit
@koppor koppor requested a review from calixtus November 16, 2025 22:55
@koppor
Copy link
Member Author

koppor commented Nov 17, 2025

Locally, JBang runs

$ jbang .jbang/JabKitLauncher.java
2025-11-17 10:41:31 [main] org.jabref.logic.preferences.JabRefCliPreferences.getFetcherKeysFromKeyring()
WARN: JabRef could not open the key store

@calixtus calixtus added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit c165a2a Nov 17, 2025
62 of 63 checks passed
@calixtus calixtus deleted the improve-jabkit-package-structure branch November 17, 2025 11:08
koppor added a commit that referenced this pull request Nov 17, 2025
Siedlerchr added a commit that referenced this pull request Nov 17, 2025
* upstream/main:
  Add smoke tests (#14338)
  Clean up packages in JabKit (#14335)
  Output binaries workflow decisions to summary (#14333)
  New translations jabref_en.properties (Portuguese, Brazilian) (#14332)
  Check for disk space only once (#14331)
  Chore(deps): Bump org.glassfish.jersey.core:jersey-server from 3.1.11 to 4.0.0 in /versions (#14305)
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
* Clean up packages in JabKit

* Fix namings

- entry point: JabKitLauncher
- command "jabkit": JabKit

* Fix main class name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants