Skip to content

Conversation

@N1hal-tech
Copy link
Contributor

(No issue associated with this small fix)

Closes

This PR fixes a small typo in the fallback window height used when JabRef corrects an out-of-bounds window position.
The previous value was 786, which is inconsistent with the intended 768 height used throughout the application’s standard fallback size (1024×768).
This ensures consistent default sizing and avoids minor UI overflow on small displays.

Steps to test

  1. Remove or temporarily rename the GUI preferences file so JabRef has no stored window coordinates.
  2. Start JabRef.
  3. Observe that the fallback window height now correctly loads as 768 instead of 786.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (not applicable – constant value change)
  • [/] I added screenshots in the PR description (not applicable – no visible UI element changed)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (not applicable – internal minor fix)
  • [/] I checked the user documentation: no updates required for this change

@github-actions
Copy link
Contributor

Hey @N1hal-tech!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️.

We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look. TragBot is still learning, and may not always be accurate. In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

@koppor
Copy link
Member

koppor commented Nov 13, 2025

@N1hal-tech Thank you for the fix. Could you add a CHANGELOG.md entry if possible?

@koppor
Copy link
Member

koppor commented Nov 13, 2025

Source code tests failing because of connection issues -- our LinkedFile is both GUI and needs remote - but we don't have a special test category for that kind of test.

@N1hal-tech
Copy link
Contributor Author

@N1hal-tech Thank you for the fix. Could you add a CHANGELOG.md entry if possible?

Thanks! I've added the CHANGELOG entry as requested.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting and fixing 💪

@koppor koppor enabled auto-merge November 13, 2025 12:58
@jabref-machine
Copy link
Collaborator

You ticked that you modified CHANGELOG.md, but no new entry was found there.

If you made changes that are visible to the user, please add a brief description along with the issue number to the CHANGELOG.md file. If you did not, please replace the cross ([x]) by a slash ([/]) to indicate that no CHANGELOG.md entry is necessary. More details can be found in our Developer Documentation about the changelog.

@koppor koppor added this pull request to the merge queue Nov 13, 2025
Merged via the queue into JabRef:main with commit baf005f Nov 13, 2025
47 of 48 checks passed
Siedlerchr added a commit that referenced this pull request Nov 13, 2025
* upstream/main: (30 commits)
  Chore(deps): Bump io.github.classgraph:classgraph from 4.8.181 to 4.8.184 in /versions (#14304)
  Chore(deps): Bump com.fasterxml:aalto-xml in /versions (#14311)
  Chore(deps): Bump commons-io:commons-io in /versions (#14310)
  Chore(deps): Bump org.apache.maven.plugins:maven-surefire-plugin (#14298)
  Disable fetcher-gui-test (#14308)
  Chore(deps): Bump com.dlsc.gemsfx:gemsfx in /versions (#14307)
  No labels for dependeabot updates
  Fix fallback window height from 786 to 768 (#14295)
  Chore(deps): Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (#14306)
  Chore(deps): Bump org.apache.maven.plugins:maven-compiler-plugin (#14302)
  Chore(deps): Bump org.apache.maven.plugins:maven-deploy-plugin (#14300)
  Chore(deps): Bump org.apache.maven.plugins:maven-clean-plugin (#14299)
  Chore(deps): Bump jablib/src/main/resources/csl-styles (#14296)
  Chore(deps): Bump com.vanniktech.maven.publish in /jablib (#14303)
  Chore(deps): Bump org.apache.maven.plugins:maven-project-info-reports-plugin (#14297)
  Update all dependencies (#14301)
  Prepare maven3 example project (#14294)
  Refactor StringUtilTest to use parameterized tests (#14126)
  Try to fix download of pr_number
  Fix workflow names
  ...
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
* Fix fallback window height from 786 to 768

* Add CHANGELOG entry for fallback window height fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants