-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: Tab bar tabs not visible #13935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| // Hide tab bar | ||
| stateManager.getOpenDatabases().addListener((ListChangeListener<BibDatabaseContext>) _ -> updateTabBarVisible()); | ||
| EasyBind.subscribe(preferences.getWorkspacePreferences().hideTabBarProperty(), _ -> updateTabBarVisible()); | ||
| tabbedPane.getTabs().addListener((ListChangeListener<Tab>) _ -> updateTabBarVisible()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch does not address the special instruction to ensure that the pull request title contains a short title of the issue fixed, rather than just 'Fix issue xyz'.
|
@koppor On PR opened/updated / Remove label "status: changes-required" (pull_request_target) fails |
Known issue. Will always fail at contributors. Maybe, you could introduce an if to check for PR source JabRef org as work around. |
Done in #13936 |
|
@trag-bot didn't find any issues in the code! ✅✨ |
Closes #13897
Steps to test
Open JabRef, then open an arbitrary library of your choice, then go to Help > Welcome Tab. You should see that the title bar is visible whenever you have both welcome tab and a library open.
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)