Skip to content

Conversation

@Yubo-Cao
Copy link
Collaborator

Closes #13897

Steps to test

Open JabRef, then open an arbitrary library of your choice, then go to Help > Welcome Tab. You should see that the title bar is visible whenever you have both welcome tab and a library open.

Mandatory checks

// Hide tab bar
stateManager.getOpenDatabases().addListener((ListChangeListener<BibDatabaseContext>) _ -> updateTabBarVisible());
EasyBind.subscribe(preferences.getWorkspacePreferences().hideTabBarProperty(), _ -> updateTabBarVisible());
tabbedPane.getTabs().addListener((ListChangeListener<Tab>) _ -> updateTabBarVisible());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch does not address the special instruction to ensure that the pull request title contains a short title of the issue fixed, rather than just 'Fix issue xyz'.

@subhramit
Copy link
Member

@koppor
Copy link
Member

koppor commented Sep 18, 2025

@koppor On PR opened/updated / Remove label "status: changes-required" (pull_request_target) fails
Could you take a look

Known issue. Will always fail at contributors. Maybe, you could introduce an if to check for PR source JabRef org as work around.

@subhramit
Copy link
Member

subhramit commented Sep 18, 2025

@koppor On PR opened/updated / Remove label "status: changes-required" (pull_request_target) fails
Could you take a look

Known issue. Will always fail at contributors. Maybe, you could introduce an if to check for PR source JabRef org as work around.

Done in #13936

@subhramit subhramit added this pull request to the merge queue Sep 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2025
@subhramit subhramit enabled auto-merge September 19, 2025 08:24
@trag-bot
Copy link

trag-bot bot commented Sep 19, 2025

@trag-bot didn't find any issues in the code! ✅✨

@subhramit subhramit added this pull request to the merge queue Sep 19, 2025
Merged via the queue into JabRef:main with commit e589b09 Sep 19, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Viewing welcome tab closes library

3 participants