Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Jun 7, 2025

Follow-up to #13112

JavaFX has to be "injected" in a different way.

Steps to test

  1. Download portable edition
  2. Start
  3. Open about dialog
  4. Check if "JavaFX" is "25-ea" or something else

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [.] Tests created for changes (if applicable)
  • [.] Manually tested changed features in running JabRef (always required)
  • [.] Screenshots added in PR description (if change is visible to the user)
  • [.] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [.] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the dev: binaries Binary builds should be uploaded to builds.jabref.org label Jun 7, 2025
@trag-bot
Copy link

trag-bot bot commented Jun 7, 2025

@trag-bot didn't find any issues in the code! ✅✨

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2025

The build of this PR is available at https://builds.jabref.org/pull/13276/merge.

@koppor
Copy link
Member Author

koppor commented Jun 14, 2025

@Siedlerchr maybe the diff regarding the javafx version is interesting.

Follow-up #13258; therefore: closing

@koppor koppor closed this Jun 14, 2025
@koppor koppor deleted the refine-ea-workflow branch June 14, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev: binaries Binary builds should be uploaded to builds.jabref.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants