Tests fail when git SSH commit signing is enabled.

[chrisdenman]

JabRef version

6.0-alpha2

Operating system

GNU / Linux

Details on version and operating system

Linux 6.8.0-71-generic amd64 / Java 24.0.2 / JavaFX 24.0.2+1

Checked with the latest development build (copy version output from About dialog)

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

1. Configure git ssh key signing.
2. Run the tests.
3. Tests that rely on git client commits fail.

Appendix

SlrGitHandlerTest.calculateDiffOnBranch

2025-08-14 16:57:57 [ForkJoinPool-1-worker-1] org.eclipse.jgit.lib.Signers.loadSigners()
ERROR: org.eclipse.jgit.lib.SignerFactory: module org.eclipse.jgit does not declare `uses`: java.util.ServiceConfigurationError: org.eclipse.jgit.lib.SignerFactory: module org.eclipse.jgit does not declare `uses`
	at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:559)
	at java.base/java.util.ServiceLoader.checkCaller(ServiceLoader.java:545)
	at java.base/java.util.ServiceLoader.<init>(ServiceLoader.java:480)
	at java.base/java.util.ServiceLoader.load(ServiceLoader.java:1547)
	at org.eclipse.jgit@7.3.0.202506031305-r/org.eclipse.jgit.lib.Signers.loadSigners(Signers.java:42)
	at org.eclipse.jgit@7.3.0.202506031305-r/org.eclipse.jgit.lib.Signers.<clinit>(Signers.java:33)
	at org.eclipse.jgit@7.3.0.202506031305-r/org.eclipse.jgit.api.CommitCommand.sign(CommitCommand.java:325)
	at org.eclipse.jgit@7.3.0.202506031305-r/org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:281)
	at org.jabref.jablib/org.jabref.logic.git.GitHandler.createCommitOnCurrentBranch(GitHandler.java:144)
	at org.jabref.jablib/org.jabref.logic.git.GitHandler.<init>(GitHandler.java:51)
	at org.jabref.jablib/org.jabref.logic.git.SlrGitHandler.<init>(SlrGitHandler.java:34)
	at org.jabref.jablib/org.jabref.logic.git.SlrGitHandlerTest.setUpGitHandler(SlrGitHandlerTest.java:32)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at org.junit.platform.commons@1.13.4/org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:787)
	at org.junit.platform.commons@1.13.4/org.junit.platform.commons.support.ReflectionSupport.invokeMethod(ReflectionSupport.java:478)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:161)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.extension.TimeoutExtension.interceptLifecycleMethod(TimeoutExtension.java:133)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.extension.TimeoutExtension.interceptBeforeEachMethod(TimeoutExtension.java:83)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.execution.InterceptingExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(InterceptingExecutableInvoker.java:112)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:94)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:93)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:87)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeMethodInExtensionContext(ClassBasedTestDescriptor.java:547)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$synthesizeBeforeEachMethodAdapter$20(ClassBasedTestDescriptor.java:532)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachMethods$2(TestMethodTestDescriptor.java:193)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.descriptor.CallbackSupport.lambda$invokeBeforeCallbacks$0(CallbackSupport.java:34)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.descriptor.CallbackSupport.invokeBeforeCallbacks(CallbackSupport.java:34)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeEachMethods(TestMethodTestDescriptor.java:191)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:155)
	at org.junit.jupiter.engine@5.13.4/org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:70)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:157)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:147)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:145)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:144)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:101)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.exec(ForkJoinPoolHierarchicalTestExecutorService.java:274)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.execSync(ForkJoinPoolHierarchicalTestExecutorService.java:247)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.executeSync(ForkJoinPoolHierarchicalTestExecutorService.java:194)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:166)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:161)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:147)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:145)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:144)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:101)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.exec(ForkJoinPoolHierarchicalTestExecutorService.java:274)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.execSync(ForkJoinPoolHierarchicalTestExecutorService.java:247)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.executeSync(ForkJoinPoolHierarchicalTestExecutorService.java:194)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:166)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:161)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:147)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:145)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:144)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:101)
	at org.junit.platform.engine@1.13.4/org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.exec(ForkJoinPoolHierarchicalTestExecutorService.java:274)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:507)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1394)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1970)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187)
2025-08-14 16:57:57 [ForkJoinPool-1-worker-1] org.jabref.logic.git.GitHandler.<init>()
ERROR: Initialization failed

SemanticConflictDetectorTest.semanticConflicts

org.eclipse.jgit.api.errors.UnsupportedSigningFormatException: No signer for ssh signatures. Use another signature type for git config gpg.format, or do not sign.
	at org.eclipse.jgit@7.3.0.202506031305-r/org.eclipse.jgit.api.CommitCommand.sign(CommitCommand.java:327)
	at org.eclipse.jgit@7.3.0.202506031305-r/org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:281)
	at org.jabref.jablib/org.jabref.logic.git.util.SemanticConflictDetectorTest.writeAndCommit(SemanticConflictDetectorTest.java:92)
	at org.jabref.jablib/org.jabref.logic.git.util.SemanticConflictDetectorTest.writeAndCommit(SemanticConflictDetectorTest.java:96)
	at org.jabref.jablib/org.jabref.logic.git.util.SemanticConflictDetectorTest.semanticConflicts(SemanticConflictDetectorTest.java:67)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at java.base/java.util.Optional.ifPresent(Optional.java:178)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:186)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:186)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:186)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1024)
	at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:807)
	at java.base/java.util.stream.ReferencePipeline$7$1FlatMap.accept(ReferencePipeline.java:294)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1024)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:153)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:176)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:636)
	at java.base/java.util.stream.ReferencePipeline$7$1FlatMap.accept(ReferencePipeline.java:294)
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1716)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:153)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:176)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:636)
	at java.base/java.util.stream.ReferencePipeline$7$1FlatMap.accept(ReferencePipeline.java:294)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:215)
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1716)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:570)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:560)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:153)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:176)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:265)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:636)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:507)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1394)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1970)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187)

SSH Configuration

user.name=Chris Denman

user.email=address@icloud.com

user.signingkey=/home/cdenman/.ssh/my_key.pub

core.autocrlf=input

init.defaultbranch=main

gpg.format=ssh

commit.gpgsign=true

tag.gpgsign=true

gpg.ssh.allowedsignersfile=/home/cdenman/.git/allowed_signers

[Siedlerchr]

Thanks for the report, that looks like there is some provider not yet configured in the gradle #13696
I filed a PR, just a question, where did you configure your singing key, in the tests?

[chrisdenman]

Thanks for the report, that looks like there is some provider not yet configured in the gradle #13696
I filed a PR, just a question, where did you configure your singing key, in the tests?

Actually, i just turned off git commit signing, to verify the tests pass:

git config --global commit.gpgsign false
git config --global tag.gpgsign false

[github-actions]

We think that this issue was fixed. Please head to https://builds.jabref.org/main to download a development build and try it out.

For any feedback, add a comment to the pull request at #13696.

[chrisdenman]

This one's resolved:

2025-08-14 16:57:57 [ForkJoinPool-1-worker-1] org.eclipse.jgit.lib.Signers.loadSigners()
ERROR: org.eclipse.jgit.lib.SignerFactory: module org.eclipse.jgit does not declare `uses`: java.util.ServiceConfigurationError: org.eclipse.jgit.lib.SignerFactory: module org.eclipse.jgit does not declare `uses`

This one is still happening:

org.eclipse.jgit.api.errors.UnsupportedSigningFormatException: No signer for ssh signatures. Use another signature type for git config gpg.format, or do not sign.

I'll see if I can get more information for you.

[Siedlerchr]

Seems to be an issue of jgit eclipse-jgit/jgit#9

[chrisdenman]

Seems to be an issue of jgit eclipse-jgit/jgit#9

Maybe. Isn't it a test isolation issue?

Why should the tests rely upon my user's git configuration (running from source but still), should they not be defining their own, known, environment?

FWIW SystemReader.getInstance().userConfig.clear() sprinkled in our tests' @BeforeEach methods, 'solves' the problem but it is somewhat brittle. JGit will still try to read the global git configuration files unlesss GIT_CONFIG_NOSYSTEM_KEY is defined.

I think the tests should enforce their own git configuration (environment) explicitly. Presumably JabRef proper doesn't rely upon the user's specific git config?

[koppor]

I think the tests should enforce their own git configuration (environment) explicitly. Presumably JabRef proper doesn't rely upon the user's specific git config?

Sure. This is the intention. Not sure why this happens. Maybe this will also happen if you use the SLR feature...

Not sure how to achieve; maybe your proposal is the way to go? Seems that JGit magically relies on the user config (which is OK in normal flow). JGit does IMHO not know if running in JUnit test or normal flow.