Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to re-enable user comments #11021

Closed
ror3d opened this issue Mar 13, 2024 · 35 comments · Fixed by #12440
Closed

Make it easier to re-enable user comments #11021

ror3d opened this issue Mar 13, 2024 · 35 comments · Fixed by #12440
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@ror3d
Copy link
Contributor

ror3d commented Mar 13, 2024

Is your suggestion for improvement related to a problem? Please describe.
When viewing the comments for an entry in the Comments tab, there are both "general" comments and user comments, and when user comments are visible, there is a button below prompting "Hide user comments". If that is clicked, the only way to re-enable user comments is through the settings. It is easy to misclick on, and a pain to have to re-enable when that happens.

Describe the solution you'd like
It would be nice for a similar button to be available in the same Comments tab to show the user comments back more easily.

Additional context

image
image
image

@koppor
Copy link
Member

koppor commented Mar 14, 2024

We are on the same page: #10424 (comment)

Other maintainers thought differently: #10610 (comment)

Not sure how to proceed. That kind of button is the only one of that kind in JabRef. Maybe more a global library setting: #10610 (comment)

@koppor
Copy link
Member

koppor commented Mar 14, 2024

Maybe another Preference: "Disable button to hide user- specific comments"? 😅

@ror3d
Copy link
Contributor Author

ror3d commented Mar 14, 2024

What I would suggest:
image
image

This would stay out of the way (leaving more space, as mentioned in #10424) and allow for enabling/disabling showing them in the same interface.

The buttons might be changed for icons instead maybe
image

but thats secondary I think.

@github-project-automation github-project-automation bot moved this to Normal priority in JabRef UI Improvements Mar 14, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Mar 14, 2024
@koppor koppor moved this from Normal priority to Low priority in JabRef UI Improvements Mar 14, 2024
@koppor koppor removed the status in Good First Issues Mar 14, 2024
@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Mar 14, 2024
@koppor
Copy link
Member

koppor commented Mar 14, 2024

@ror3d Thank you for your UI sketches. This way, this issue becomes a "good first issue" which can be handled by students.

@Realmbird
Copy link

Can I take this issue

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Mar 15, 2024
@ThiloteE ThiloteE moved this from Free to take to Reserved in Candidates for University Projects Mar 15, 2024
@ThiloteE ThiloteE moved this to Reserved in Good First Issues Mar 15, 2024
@Realmbird
Copy link

Realmbird commented Mar 17, 2024

setting up gitter is there an iPhone app for it? I see gitter lite and it looks different from gitter on computer

@Siedlerchr
Copy link
Member

@Realmbird yo should be able to use any matrix client I guess https://app.gitter.im/#/room/#JabRef_jabref:gitter.im

@Realmbird
Copy link

Realmbird commented Mar 19, 2024

currently getting student developer for github for ide, got accepted just waiting for benefits

@koppor
Copy link
Member

koppor commented Mar 19, 2024

I think the Community edition of IntellIj works well, too. Just try!

@Realmbird
Copy link

Ok

@Realmbird
Copy link

Realmbird commented Mar 21, 2024

Finally got environment setup, took me time since I am open source beginner. Now I am gonna try fixing problem

@Realmbird
Copy link

Realmbird commented Mar 21, 2024

@koppor @ror3d I have a question I understand I my idea of a solution is to have a show user comment button in the comment tab where the hide user comments. Also how do I get entries to check the comments for since after running JabRef I see no entries.

@Realmbird
Copy link

Screenshot from 2024-03-20 17-23-45

@Realmbird
Copy link

Screenshot from 2024-03-20 17-28-17
How does the page code work with java I tried git grep for hide user comments and not sure how the pages load with java

@Siedlerchr
Copy link
Member

You need to create a new library and add entries or open an existing one

@koppor
Copy link
Member

koppor commented Mar 21, 2024

Maybe the user documentation of JabRef helps to understand the tool usage? Check https://docs.jabref.org/collect/add-entry-manually for instance.

@Siedlerchr Siedlerchr added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Sep 27, 2024
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@Siedlerchr Siedlerchr moved this from Free to take to Reserved in Candidates for University Projects Sep 27, 2024
@Siedlerchr Siedlerchr moved this from Free to take to Reserved in Good First Issues Sep 27, 2024
@koppor koppor added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Oct 13, 2024
@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Nov 13, 2024
@calixtus calixtus moved this from Normal priority to Low priority in Prioritization Nov 13, 2024
@ThiloteE
Copy link
Member

Are you still on it?

@ThiloteE ThiloteE moved this from Assigned to Free to take in Candidates for University Projects Jan 20, 2025
@ThiloteE ThiloteE moved this from Assigned to Free to take in Good First Issues Jan 20, 2025
@SihasA
Copy link
Contributor

SihasA commented Jan 24, 2025

Hi, I am part of a King's College London student team working with @LinusDietz . Could we tackle this issue?

@LinusDietz
Copy link
Member

I think it's a good one, and it looks to be free to take.

@Siedlerchr Siedlerchr removed FirstTimeCodeContribution Triggers GitHub Greeter Workflow 📍 Assigned Assigned by assign-issue-action (or manually assigned) labels Jan 24, 2025
@Siedlerchr
Copy link
Member

/assign @SihasA

@SihasA
Copy link
Contributor

SihasA commented Jan 24, 2025

@koppor what did you mean by this?

  1. Do NEITHER show "Show user-specific comments field" nor "Hide user-specific comments field" if user-specific comment already shown.

Should we not show the "Hide user-specified comments field" or "Show user-specific comments field" buttons if the user-specified comment field is not empty?

@SihasA
Copy link
Contributor

SihasA commented Jan 27, 2025

Hi there! I think I was unassigned- hoping to launch a PR tomorrow for this issue.

@Siedlerchr Siedlerchr added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Jan 27, 2025
@github-project-automation github-project-automation bot moved this from Free to take to Done in Good First Issues Feb 8, 2025
@github-project-automation github-project-automation bot moved this from Free to take to Done in Candidates for University Projects Feb 8, 2025
@github-project-automation github-project-automation bot moved this from Low priority to Done in Prioritization Feb 8, 2025
@Siedlerchr
Copy link
Member

@ror3d This issue is now resolved in the latest dev version!

@ror3d
Copy link
Contributor Author

ror3d commented Feb 9, 2025

TY I'll take a look next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: ui good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Status: Done
Status: Done
9 participants