From f51ba4962d98eae4ea6016f05f8ed2015f484d1a Mon Sep 17 00:00:00 2001 From: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Sun, 18 Aug 2019 14:45:58 +0200 Subject: [PATCH] Conversion of preferencesDialog/advancedTab, networkTab and groupsTab to mvvm (#5141) * Converting to mvvm, combining advanced and network * Refactor minor things and cosmetic changes * Convert GroupsTab to mvvm * Fixed l10n * Refactor, reword, abstract and added resetWarning * Reword * Refactored for better readability * Rewording for consistency, trigger travis * Fixed minor bug * Refixed minor bug --- src/main/java/org/jabref/gui/Base.css | 5 + .../java/org/jabref/gui/icon/IconTheme.java | 3 +- .../AbstractPreferenceTabView.java | 37 +++ .../jabref/gui/preferences/AdvancedTab.fxml | 67 +++++ .../jabref/gui/preferences/AdvancedTab.java | 176 ------------ .../gui/preferences/AdvancedTabView.java | 131 +++++++++ .../gui/preferences/AdvancedTabViewModel.java | 253 ++++++++++++++++++ .../gui/preferences/AppearancePrefsTab.java | 8 +- .../preferences/BibtexKeyPatternPrefTab.java | 8 +- .../gui/preferences/EntryEditorPrefsTab.java | 8 +- .../preferences/ExportSortingPrefsTab.java | 8 +- .../jabref/gui/preferences/ExternalTab.fxml | 175 ++++++------ .../gui/preferences/ExternalTabView.java | 114 ++++---- .../gui/preferences/ExternalTabViewModel.java | 6 + .../org/jabref/gui/preferences/FileTab.fxml | 27 +- .../jabref/gui/preferences/FileTabView.java | 96 +++---- .../gui/preferences/FileTabViewModel.java | 7 +- .../jabref/gui/preferences/GeneralTab.fxml | 59 ++-- .../gui/preferences/GeneralTabView.java | 114 ++++---- .../gui/preferences/GeneralTabViewModel.java | 31 ++- .../gui/preferences/GroupsPrefsTab.java | 122 --------- .../org/jabref/gui/preferences/GroupsTab.fxml | 47 ++++ .../jabref/gui/preferences/GroupsTabView.java | 44 +++ .../gui/preferences/GroupsTabViewModel.java | 83 ++++++ .../gui/preferences/ImportSettingsTab.java | 6 +- .../gui/preferences/NameFormatterTab.java | 5 +- .../jabref/gui/preferences/NetworkTab.java | 195 -------------- .../preferences/PreferenceTabViewModel.java | 30 +++ .../preferences/PreferencesDialogView.java | 8 +- .../PreferencesDialogViewModel.java | 60 +++-- .../preferences/PreferencesSearchHandler.java | 26 +- .../gui/preferences/PreferencesTab.java | 50 ++++ .../org/jabref/gui/preferences/PrefsTab.java | 46 ---- .../gui/preferences/PreviewTabView.java | 119 ++++---- .../gui/preferences/PreviewTabViewModel.java | 19 +- .../gui/preferences/TableColumnsTab.java | 5 +- .../jabref/gui/preferences/TablePrefsTab.java | 8 +- .../jabref/gui/preferences/XmpPrefsTab.java | 6 +- .../gui/push/PushToApplicationSettings.java | 2 + .../org/jabref/logic/net/ProxyRegisterer.java | 4 +- src/main/resources/l10n/JabRef_en.properties | 28 +- 41 files changed, 1200 insertions(+), 1046 deletions(-) create mode 100644 src/main/java/org/jabref/gui/preferences/AbstractPreferenceTabView.java create mode 100644 src/main/java/org/jabref/gui/preferences/AdvancedTab.fxml delete mode 100644 src/main/java/org/jabref/gui/preferences/AdvancedTab.java create mode 100644 src/main/java/org/jabref/gui/preferences/AdvancedTabView.java create mode 100644 src/main/java/org/jabref/gui/preferences/AdvancedTabViewModel.java delete mode 100644 src/main/java/org/jabref/gui/preferences/GroupsPrefsTab.java create mode 100644 src/main/java/org/jabref/gui/preferences/GroupsTab.fxml create mode 100644 src/main/java/org/jabref/gui/preferences/GroupsTabView.java create mode 100644 src/main/java/org/jabref/gui/preferences/GroupsTabViewModel.java delete mode 100644 src/main/java/org/jabref/gui/preferences/NetworkTab.java create mode 100644 src/main/java/org/jabref/gui/preferences/PreferencesTab.java delete mode 100644 src/main/java/org/jabref/gui/preferences/PrefsTab.java diff --git a/src/main/java/org/jabref/gui/Base.css b/src/main/java/org/jabref/gui/Base.css index c913bb5ad9e..5236268d894 100644 --- a/src/main/java/org/jabref/gui/Base.css +++ b/src/main/java/org/jabref/gui/Base.css @@ -1015,6 +1015,11 @@ We want to have a look that matches our icons in the tool-bar */ -fx-fill: -jr-warn; } +.warning-message { + -fx-fill: -jr-error; + -fx-text-fill: -jr-error; +} + .error-icon { -fx-text-fill: -jr-error; -fx-fill: -jr-error; diff --git a/src/main/java/org/jabref/gui/icon/IconTheme.java b/src/main/java/org/jabref/gui/icon/IconTheme.java index 6e9dca496b1..39e0ff48d0b 100644 --- a/src/main/java/org/jabref/gui/icon/IconTheme.java +++ b/src/main/java/org/jabref/gui/icon/IconTheme.java @@ -321,7 +321,8 @@ public enum JabRefIcons implements JabRefIcon { LATEX_FILE_DIRECTORY(MaterialDesignIcon.FOLDER_OUTLINE), LATEX_FILE(MaterialDesignIcon.FILE_OUTLINE), LATEX_COMMENT(MaterialDesignIcon.COMMENT_TEXT_OUTLINE), - LATEX_LINE(MaterialDesignIcon.FORMAT_LINE_SPACING); + LATEX_LINE(MaterialDesignIcon.FORMAT_LINE_SPACING), + PASSWORD_REVEALED(MaterialDesignIcon.EYE); private final JabRefIcon icon; diff --git a/src/main/java/org/jabref/gui/preferences/AbstractPreferenceTabView.java b/src/main/java/org/jabref/gui/preferences/AbstractPreferenceTabView.java new file mode 100644 index 00000000000..b957082890b --- /dev/null +++ b/src/main/java/org/jabref/gui/preferences/AbstractPreferenceTabView.java @@ -0,0 +1,37 @@ +package org.jabref.gui.preferences; + +import java.util.List; + +import javax.inject.Inject; + +import javafx.scene.Node; +import javafx.scene.layout.VBox; + +import org.jabref.gui.DialogService; +import org.jabref.gui.util.TaskExecutor; +import org.jabref.preferences.JabRefPreferences; + +public abstract class AbstractPreferenceTabView extends VBox implements PreferencesTab { + + @Inject protected TaskExecutor taskExecutor; + @Inject protected DialogService dialogService; + + protected PreferenceTabViewModel viewModel; + + protected JabRefPreferences preferences; + + @Override + public Node getBuilder() { return this; } + + @Override + public void setValues() { viewModel.setValues(); } + + @Override + public void storeSettings() { viewModel.storeSettings(); } + + @Override + public boolean validateSettings() { return viewModel.validateSettings(); } + + @Override + public List getRestartWarnings() { return viewModel.getRestartWarnings(); } +} diff --git a/src/main/java/org/jabref/gui/preferences/AdvancedTab.fxml b/src/main/java/org/jabref/gui/preferences/AdvancedTab.fxml new file mode 100644 index 00000000000..ae24bdd63bd --- /dev/null +++ b/src/main/java/org/jabref/gui/preferences/AdvancedTab.fxml @@ -0,0 +1,67 @@ + + + + + + + + + + + + + + + + +