Fix porcelain for consistency check (#13209)

* Add progess output for consisteny check

Fixes #12487

* better handling of not present

* checkstyle

* fix test

* fix newline

* check for porcelain

* fix formatting

* fix formatting

Author: Siedlerchr

jabkit/src/main/java/org/jabref/cli/CheckConsistency.java

@@ -66,7 +66,9 @@ public void run() {
 
         BibliographyConsistencyCheck consistencyCheck = new BibliographyConsistencyCheck();
         BibliographyConsistencyCheck.Result result = consistencyCheck.check(entries, (count, total) -> {
-            System.out.println(Localization.lang("Checking consistency for entry type %0 of %1", count + 1, total));
+            if (!sharedOptions.porcelain) {
+                System.out.println(Localization.lang("Checking consistency for entry type %0 of %1", count + 1, total));
+            }
         });
 
         Writer writer = new OutputStreamWriter(System.out);

jabkit/src/test/java/org/jabref/cli/ArgumentProcessorTest.java

@@ -146,6 +146,7 @@ void checkConsistency() throws URISyntaxException {
         commandLine.execute(args.toArray(String[]::new));
 
         String output = outContent.toString();
+        assertTrue(output.contains("Checking consistency for entry type 1 of 1\n"));
         assertTrue(output.contains("Consistency check completed"));
 
         System.setOut(System.out);
@@ -165,7 +166,7 @@ void checkConsistencyPorcelain() throws URISyntaxException {
         commandLine.execute(args.toArray(String[]::new));
 
         String output = outContent.toString();
-        assertEquals("Checking consistency for entry type 1 of 1\n", output);
+        assertEquals("", output);
 
         System.setOut(System.out);
     }

jablib/src/main/java/org/jabref/logic/quality/consistency/BibliographyConsistencyCheck.java

@@ -83,13 +83,13 @@ private static void collectEntriesIntoMaps(List<BibEntry> entries, Map<EntryType
         for (BibEntry entry : entries) {
             EntryType entryType = entry.getType();
 
-            Set<Field> fieldsInAnyEntry = entryTypeToFieldsInAnyEntryMap.computeIfAbsent(entryType, k -> new HashSet<>());
+            Set<Field> fieldsInAnyEntry = entryTypeToFieldsInAnyEntryMap.computeIfAbsent(entryType, _ -> new HashSet<>());
             fieldsInAnyEntry.addAll(entry.getFields());
 
-            Set<Field> fieldsInAllEntries = entryTypeToFieldsInAllEntriesMap.computeIfAbsent(entryType, k -> new HashSet<>(entry.getFields()));
+            Set<Field> fieldsInAllEntries = entryTypeToFieldsInAllEntriesMap.computeIfAbsent(entryType, _ -> new HashSet<>(entry.getFields()));
             fieldsInAllEntries.retainAll(entry.getFields());
 
-            Set<BibEntry> entriesOfType = entryTypeToEntriesMap.computeIfAbsent(entryType, k -> new HashSet<>());
+            Set<BibEntry> entriesOfType = entryTypeToEntriesMap.computeIfAbsent(entryType, _ -> new HashSet<>());
             entriesOfType.add(entry);
         }
     }