Fix background color of dialogs in dark mode (#4994)

davidemdot · tobiasdiez · commit d3b193ce1652 · 2019-05-24T10:24:30.000+02:00
* Fix background color of dialogs in dark mode * Update CHANGELOG * Add new line at end of Base.css * Revert "Update CHANGELOG" This reverts commit 13a313a.
diff --git a/src/main/java/org/jabref/gui/Base.css b/src/main/java/org/jabref/gui/Base.css
@@ -1032,3 +1032,7 @@ We want to have a look that matches our icons in the tool-bar */
     -fx-font-size: 1.5em;
     -fx-padding: 1em 0em 1em 0em;
 }
+
+.dialog-pane {
+    -fx-background-color: -fx-control-inner-background;
+}
diff --git a/src/main/java/org/jabref/gui/help/AboutDialog.css b/src/main/java/org/jabref/gui/help/AboutDialog.css
@@ -1,9 +1,10 @@
 .about-heading {
     -fx-font-size: 30;
+    -fx-text-fill: -jr-theme;
 }
 
 .about-heading:pressed {
-	-fx-text-fill: -fx-focus-color;
+    -fx-text-fill: -jr-selected;
 }
 
 .top-padding {
@@ -33,7 +34,7 @@
 }
 
 .info-sections {
-	-fx-padding: 5px;
+    -fx-padding: 5px;
 }
 
 .logo-pane {
diff --git a/src/main/java/org/jabref/gui/preferences/PreferencesDialog.css b/src/main/java/org/jabref/gui/preferences/PreferencesDialog.css
@@ -1,12 +1,12 @@
 #sideMenu {
-    -fx-background-color: -jr-white;
+    -fx-background-color: -fx-control-inner-background;
     -fx-border-color: -fx-outer-border;
     -fx-border-width: 1;
 }
 
 #sideMenu > .virtual-flow > .clipped-container > .sheet > .list-cell {
     -fx-padding: 8 8 8 8;
-    -fx-background: -jr-white;
+    -fx-background: -fx-control-inner-background;
 }
 
 .preferencePaneContainer {

Original file line number	Diff line number	Diff line change
`@@ -1032,3 +1032,7 @@ We want to have a look that matches our icons in the tool-bar */`
`1032`	`1032`	`-fx-font-size: 1.5em;`
`1033`	`1033`	`-fx-padding: 1em 0em 1em 0em;`
`1034`	`1034`	`}`
	`1035`	`+`
	`1036`	`+.dialog-pane {`
	`1037`	`+ -fx-background-color: -fx-control-inner-background;`
	`1038`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,10 @@`
`1`	`1`	`.about-heading {`
`2`	`2`	`-fx-font-size: 30;`
	`3`	`+ -fx-text-fill: -jr-theme;`
`3`	`4`	`}`
`4`	`5`
`5`	`6`	`.about-heading:pressed {`
`6`		`- -fx-text-fill: -fx-focus-color;`
	`7`	`+ -fx-text-fill: -jr-selected;`
`7`	`8`	`}`
`8`	`9`
`9`	`10`	`.top-padding {`
`@@ -33,7 +34,7 @@`
`33`	`34`	`}`
`34`	`35`
`35`	`36`	`.info-sections {`
`36`		`- -fx-padding: 5px;`
	`37`	`+ -fx-padding: 5px;`
`37`	`38`	`}`
`38`	`39`
`39`	`40`	`.logo-pane {`
Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,12 @@`
`1`	`1`	`#sideMenu {`
`2`		`- -fx-background-color: -jr-white;`
	`2`	`+ -fx-background-color: -fx-control-inner-background;`
`3`	`3`	`-fx-border-color: -fx-outer-border;`
`4`	`4`	`-fx-border-width: 1;`
`5`	`5`	`}`
`6`	`6`
`7`	`7`	`#sideMenu > .virtual-flow > .clipped-container > .sheet > .list-cell {`
`8`	`8`	`-fx-padding: 8 8 8 8;`
`9`		`- -fx-background: -jr-white;`
	`9`	`+ -fx-background: -fx-control-inner-background;`
`10`	`10`	`}`
`11`	`11`
`12`	`12`	`.preferencePaneContainer {`