Skip to content

Commit d281ece

Browse files
Le-wiSiedlerchr
authored andcommitted
Add uncaught exception message (#4565)
* Add error message for uncaught exceptions Added a new view to the project. It's shown after the uncaught exception is logged. * Add simple text to fallback error view Added a label asking the user to look into the logfiles for more details. * Add error message to language files Added the error message to the german and english language files. * Add ErrorDialogAndWait Removed the FallbackErrorView. Added the showErrorDialogAndWait call instead.
1 parent e1cfec9 commit d281ece

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
9191
- We fixed an issue where only one PDF file could be imported [#4422](https://github.com/JabRef/jabref/issues/4422)
9292
- We fixed an issue where "Move to group" would always move the first entry in the library and not the selected [#4414](https://github.com/JabRef/jabref/issues/4414)
9393
- We fixed an issue where an older dialog appears when downloading full texts from the quality menu. [#4489](https://github.com/JabRef/jabref/issues/4489)
94-
94+
- We fixed an issue where uncaught exceptions were logged but the user wasn't informed about their occurance. [#2288] (https://github.com/JabRef/jabref/issues/2288)
9595

9696

9797

src/main/java/org/jabref/FallbackExceptionHandler.java

+4
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,9 @@ public static void installExceptionHandler() {
1717
@Override
1818
public void uncaughtException(Thread thread, Throwable exception) {
1919
LOGGER.error("Uncaught exception occurred in " + thread, exception);
20+
JabRefGUI.getMainFrame()
21+
.getDialogService()
22+
.showErrorDialogAndWait(
23+
exception.getLocalizedMessage(), exception);
2024
}
2125
}

src/main/resources/l10n/JabRef_de.properties

-3
Original file line numberDiff line numberDiff line change
@@ -2200,6 +2200,3 @@ Website=Webseite
22002200
Write\ XMP-metadata\ to\ PDFs=&XMP-Metadaten in PDFs schreiben
22012201

22022202
Override\ default\ font\ settings=Standardschrifteinstellungen überschreiben
2203-
2204-
2205-

src/main/resources/l10n/JabRef_en.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -2239,4 +2239,4 @@ Main\ layout\ file\:=Main layout file\:
22392239
Main\ layout\ file=Main layout file
22402240
Save\ exporter=Save exporter
22412241
File\ extension\:=File extension\:
2242-
Export\ format\ name\:=Export format name\:
2242+
Export\ format\ name\:=Export format name\:

0 commit comments

Comments
 (0)