Merge branch 'add-ICORE-ranking-support' of https://github.com/TheYorouzoya/jabref into add-ICORE-ranking-support

Author: TheYorouzoya

.github/workflows/publish.yml

@@ -1,16 +1,25 @@
 name: Publish to maven central
 
 on:
-  pull_request:
+  # On releases
   push:
-    branches:
-      - main
     tags:
       - '**'
-  schedule:
-    # Run on each Monday
-    # Additional run in addition to the other events, because some resources could have changes
-    - cron: '2 3 * * 1'
+
+  # Called by the JBang testing jobs to ensure that SNAPSHOT is uptodate
+  workflow_call:
+    secrets:
+      KOPPOR_SIGNING_SECRETKEYRINGFILE_BASE64:
+        required: true
+      KOPPOR_SIGNING_KEYID:
+        required: true
+      KOPPOR_SIGNING_PASSWORD:
+        required: true
+      KOPPOR_MAVENCENTRALUSERNAME:
+        required: true
+      KOPPOR_MAVENCENTRALPASSWORD:
+        required: true
+
   workflow_dispatch:
     inputs:
       tagbuild:
@@ -19,6 +28,11 @@ on:
         default: false
         type: boolean
 
+  # Additional run in addition to the other events, because some resources could have changes
+  schedule:
+    # Run on each Monday
+    - cron: '2 3 * * 1'
+
 permissions:
   actions: write
   contents: read
@@ -56,7 +70,8 @@ jobs:
       github.event_name == 'schedule' ||
       github.event_name == 'workflow_dispatch' ||
       (needs.detect_changes.outputs.changed == 'true' &&
-        ((github.event_name == 'push' && github.repository == 'JabRef/jabref') ||
+        ((github.event_name == 'workflow_call' && github.repository == 'JabRef/jabref') ||
+         (github.event_name == 'push' && github.repository == 'JabRef/jabref') ||
          (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == 'JabRef/jabref'))
       )
     runs-on: ubuntu-latest

.github/workflows/tests-code.yml

@@ -8,11 +8,7 @@ on:
   pull_request:
   merge_group:
   workflow_dispatch:
-  # Re-run JBang tests after the SNAPSHOT is updated
-  workflow_run:
-    workflows: ["Publish to maven central"]
-    types:
-      - completed
+
 env:
   AstrophysicsDataSystemAPIKey: ${{ secrets.AstrophysicsDataSystemAPIKey_FOR_TESTS }}
   BiodiversityHeritageApiKey: ${{ secrets.BiodiversityHeritageApiKey_FOR_TESTS}}
@@ -26,6 +22,9 @@ concurrency:
   cancel-in-progress: true
 
 permissions:
+  # required for publish.yml
+  actions: write
+  contents: read
   pull-requests: write
 
 jobs:
@@ -397,9 +396,20 @@ jobs:
           CI: "true"
           DBMS: "postgresql"
 
+  publish:
+    if: github.ref == 'refs/heads/main'
+    uses: ./.github/workflows/publish.yml
+    secrets:
+      KOPPOR_SIGNING_SECRETKEYRINGFILE_BASE64: ${{ secrets.KOPPOR_SIGNING_SECRETKEYRINGFILE_BASE64 }}
+      KOPPOR_SIGNING_KEYID: ${{ secrets.KOPPOR_SIGNING_KEYID }}
+      KOPPOR_SIGNING_PASSWORD: ${{ secrets.KOPPOR_SIGNING_PASSWORD }}
+      KOPPOR_MAVENCENTRALUSERNAME: ${{ secrets.KOPPOR_MAVENCENTRALUSERNAME }}
+      KOPPOR_MAVENCENTRALPASSWORD: ${{ secrets.KOPPOR_MAVENCENTRALPASSWORD }}
+
   jbang:
     name: JBang (main)
     runs-on: ubuntu-latest
+    needs: publish
     if: github.ref == 'refs/heads/main'
     steps:
       - name: Checkout source
@@ -435,6 +445,7 @@ jobs:
   jbang-pr:
     name: JBang (PR)
     runs-on: ubuntu-latest
+    # does not need publish, because the JBang scripts are modified
     if: github.ref != 'refs/heads/main'
     strategy:
       fail-fast: false
@@ -472,6 +483,8 @@ jobs:
         with:
           files: |
             jablib/src/main/java/**/*.java
+          files_ignore: |
+            jablib/src/main/java/**/*-*.java
 
       - name: Build ${{ matrix.launcher }} launcher including changed classes
         shell: bash

.jbang/JabSrvLauncher.java

@@ -65,7 +65,7 @@
 //DEPS info.picocli:picocli:4.7.7
 //DEPS org.postgresql:postgresql:42.7.7
 //DEPS org.bouncycastle:bcprov-jdk18on:1.81
-//DEPS com.konghq:unirest-modules-gson:4.5.0
+//DEPS com.konghq:unirest-modules-gson:4.5.1
 //DEPS jakarta.ws.rs:jakarta.ws.rs-api:4.0.0
 //DEPS org.glassfish.jersey.core:jersey-server:3.1.11
 //DEPS org.glassfish.jersey.inject:jersey-hk2:3.1.11
@@ -77,7 +77,7 @@
 //DEPS org.glassfish.grizzly:grizzly-framework:4.0.2
 //DEPS jakarta.validation:jakarta.validation-api:3.1.1
 //DEPS org.hibernate.validator:hibernate-validator:9.0.1.Final
-//DEPS com.konghq:unirest-modules-gson:4.5.0
+//DEPS com.konghq:unirest-modules-gson:4.5.1
 //DEPS com.google.guava:guava:33.4.8-jre
 //DEPS org.jabref:afterburner.fx:2.0.0
 //DEPS net.harawata:appdirs:1.4.0

CHANGELOG.md

@@ -11,6 +11,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 
 ### Added
 
+- We fixed an issue where "Print preview" would throw a `NullPointerException` if no printers were available. [#13708](https://github.com/JabRef/jabref/issues/13708)
 - We added the option to enable the language server in the preferences. [#13697](https://github.com/JabRef/jabref/pull/13697)
 - We introduced an option in Preferences under (under Linked files -> Linked file name conventions) to automatically rename linked files when an entry data changes. [#11316](https://github.com/JabRef/jabref/issues/11316)
 - We added tooltips (on hover) for 'Library-specific file directory', 'User-specific file directory' and 'LaTeX file directory' fields of the library properties window. [#12269](https://github.com/JabRef/jabref/issues/12269)
@@ -27,6 +28,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We added a new ID based fetcher for [EuropePMC](https://europepmc.org/). [#13389](https://github.com/JabRef/jabref/pull/13389)
 - We added quick settings for welcome tab. [#12664](https://github.com/JabRef/jabref/issues/12664)
 - We added an initial [cite as you write](https://retorque.re/zotero-better-bibtex/citing/cayw/) endpoint. [#13187](https://github.com/JabRef/jabref/issues/13187)
+- We added pagination support for the web search entries dialog, improving navigation for large search results. [#5507](https://github.com/JabRef/jabref/issues/5507)
 - We added "copy preview as markdown" feature. [#12552](https://github.com/JabRef/jabref/issues/12552)
 - In case no citation relation information can be fetched, we show the data providers reason. [#13549](https://github.com/JabRef/jabref/pull/13549)
 - When relativizing file names, symlinks are now taken into account. [#12995](https://github.com/JabRef/jabref/issues/12995)
@@ -37,6 +39,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 
 ### Changed
 
+- We changed `ISSNCleanup` into `NormalizeIssn` a `ISSN` formatter. [#13748](https://github.com/JabRef/jabref/issues/13748)
 - We changed Citation Relations tab and gave tab panes more descriptive titles and tooltips. [#13619](https://github.com/JabRef/jabref/issues/13619)
 - We changed the name from Open AI Provider to Open AI (or API compatible). [#13585](https://github.com/JabRef/jabref/issues/13585)
 - We improved the citations relations caching by implementing an offline storage. [#11189](https://github.com/JabRef/jabref/issues/11189)
@@ -74,6 +77,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We improved JabRef's internal document viewer. It now allows text section, searching and highlighting of search terms and page rotation [#13193](https://github.com/JabRef/jabref/pull/13193).
 - When importing a PDF, there is no empty entry column shown in the multi merge dialog. [#13132](https://github.com/JabRef/jabref/issues/13132)
 - We added a progress dialog to the "Check consistency" action and progress output to the corresponding cli command. [#12487](https://github.com/JabRef/jabref/issues/12487)
+- The BibTeX source is now formatted using the JabRef style at the import inspection dialog. [#13015](https://github.com/JabRef/jabref/issues/13015)
 - We made the `check-consistency` command of the toolkit always return an exit code; 0 means no issues found, a non-zero exit code reflects any issues, which allows CI to fail in these cases [#13328](https://github.com/JabRef/jabref/issues/13328).
 - We changed the validation error dialog for overriding the default file directories to a confirmation dialog for saving other preferences under the library properties. [#13488](https://github.com/JabRef/jabref/pull/13488)
 - We made the copy sub menu on the context menu consistent with the copy sub menu at "Edit". [#13280](https://github.com/JabRef/jabref/pull/13280)
@@ -82,6 +86,9 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - The Welcome tab now has a responsive layout. [#12664](https://github.com/JabRef/jabref/issues/12664)
 - We introduced a donation prompt in the Welcome tab. [#12664](https://github.com/JabRef/jabref/issues/12664)
 - We changed to syntax for the websearch to the one of the main search bar. [#13607](https://github.com/JabRef/jabref/issues/13607)
+- We improved the for the web search tab in the preferences dialog [#13791](https://github.com/JabRef/jabref/pull/13791)
+- We improved the event viewer for debugging [#13783](https://github.com/JabRef/jabref/pull/13783).
+- We improved "REDACTED" replacement of API key value in web fetcher search URL [#13796](https://github.com/JabRef/jabref/issues/13796)
 
 ### Fixed
 
@@ -110,11 +117,15 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We fixed an issue showing an empty tooltip in maintable. [#11681](https://github.com/JabRef/jabref/issues/11681)
 - We fixed an issue displaying a warning if a file to open is not found. [#13430](https://github.com/JabRef/jabref/pull/13430)
 - We fixed an issue where Document Viewer showed technical exceptions when opening entries with non-PDF files. [#13198](https://github.com/JabRef/jabref/issues/13198)
+- We fixed an issue with double display of the library filename in the tab tooltip in the case of a changed library. [#13781](https://github.com/JabRef/jabref/pull/13781)
 - When creating a library, if you drag a PDF file containing only a single column, the dialog will now automatically close. [#13262](https://github.com/JabRef/jabref/issues/13262)
-- We fixed an issue where the tab showing the fulltext search results would appear blank after switching library. [#13241](https://github.com/JabRef/jabref/issues/13241)
+- We fixed an issue where the tab showing the fulltext search results would appear blank after switching libraries. [#13241](https://github.com/JabRef/jabref/issues/13241)
 - We fixed an issue where "Copy to" was enabled even if no other library was opened. [#13280](https://github.com/JabRef/jabref/pull/13280)
 - We fixed an issue where the groups were still displayed after closing all libraries. [#13382](https://github.com/JabRef/jabref/issues/13382)
 - Enhanced field selection logic in the Merge Entries dialog when fetching from DOI to prefer valid years and entry types. [#12549](https://github.com/JabRef/jabref/issues/12549)
+- We improved consistency in the Add Buttons. [#13791](https://github.com/JabRef/jabref/pull/13791)
+- We fixed an issue where theme or font size are not respected for all dialogs [#13558](https://github.com/JabRef/jabref/issues/13558)
+- We removed unnecessary spacing and margin in the AutomaticFieldEditor. [#13792](https://github.com/JabRef/jabref/pull/13792)
 
 ### Removed
 

build-logic/build.gradle.kts

@@ -10,7 +10,7 @@ repositories {
 
 dependencies {
     implementation("com.adarshr:gradle-test-logger-plugin:4.0.0")
-    implementation("com.autonomousapps:dependency-analysis-gradle-plugin:3.0.0")
+    implementation("com.autonomousapps:dependency-analysis-gradle-plugin:3.0.1")
     implementation("com.github.andygoossens:gradle-modernizer-plugin:1.11.0")
     implementation("org.gradlex:extra-java-module-info:1.13")
     implementation("org.gradlex:java-module-dependencies:1.9.2")

build.gradle.kts

@@ -1,15 +1,15 @@
 plugins {
     id("org.jabref.gradle.base.repositories")
     id("org.jabref.gradle.feature.compile") // for openrewrite
-    id("org.openrewrite.rewrite") version "7.14.1"
+    id("org.openrewrite.rewrite") version "7.15.0"
     id("org.itsallcode.openfasttrace") version "3.1.0"
 }
 
 // OpenRewrite should rewrite all sources
 // This is the behavior when applied in the root project (https://docs.openrewrite.org/reference/gradle-plugin-configuration#multi-module-gradle-projects)
 
 dependencies {
-    rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:3.13.0"))
+    rewrite(platform("org.openrewrite.recipe:rewrite-recipe-bom:3.14.0"))
     rewrite("org.openrewrite.recipe:rewrite-static-analysis")
     rewrite("org.openrewrite.recipe:rewrite-logging-frameworks")
     rewrite("org.openrewrite.recipe:rewrite-testing-frameworks")