Skip to content

Commit 73ec321

Browse files
NivedhaSunderrajtobiasdiez
authored andcommitted
Fixed testExportAsModsAndThenImportAsMods (#4369)
* Fixed testExportAsModsAndThenImportAsMods * Fixed indentation * Fixed indentation
1 parent 79ba040 commit 73ec321

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

src/test/java/org/jabref/logic/exporter/ModsExportFormatTestFiles.java

+10-9
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
package org.jabref.logic.exporter;
22

3+
import static org.hamcrest.MatcherAssert.assertThat;
4+
import static org.mockito.Mockito.mock;
5+
36
import java.nio.charset.Charset;
47
import java.nio.charset.StandardCharsets;
58
import java.nio.file.Files;
@@ -16,23 +19,20 @@
1619
import org.jabref.model.database.BibDatabaseContext;
1720
import org.jabref.model.entry.BibEntry;
1821
import org.jabref.model.util.DummyFileUpdateMonitor;
19-
2022
import org.junit.jupiter.api.BeforeEach;
2123
import org.junit.jupiter.api.Disabled;
2224
import org.junit.jupiter.api.extension.ExtendWith;
2325
import org.junit.jupiter.params.ParameterizedTest;
2426
import org.junit.jupiter.params.provider.MethodSource;
2527
import org.junitpioneer.jupiter.TempDirectory;
2628
import org.mockito.Answers;
29+
import org.mockito.Mockito;
2730
import org.xmlunit.builder.Input;
2831
import org.xmlunit.builder.Input.Builder;
2932
import org.xmlunit.diff.DefaultNodeMatcher;
3033
import org.xmlunit.diff.ElementSelectors;
3134
import org.xmlunit.matchers.CompareMatcher;
3235

33-
import static org.hamcrest.MatcherAssert.assertThat;
34-
import static org.mockito.Mockito.mock;
35-
3636
@ExtendWith(TempDirectory.class)
3737
public class ModsExportFormatTestFiles {
3838

@@ -65,8 +65,10 @@ public void setUp(@TempDirectory.TempDir Path testFolder) throws Exception {
6565
Path path = testFolder.resolve("ARandomlyNamedFile.tmp");
6666
Files.createFile(path);
6767
tempFile = path.toAbsolutePath();
68-
bibtexImporter = new BibtexImporter(mock(ImportFormatPreferences.class, Answers.RETURNS_DEEP_STUBS), new DummyFileUpdateMonitor());
69-
modsImporter = new ModsImporter(mock(ImportFormatPreferences.class, Answers.RETURNS_DEEP_STUBS));
68+
ImportFormatPreferences mock = mock(ImportFormatPreferences.class, Answers.RETURNS_DEEP_STUBS);
69+
bibtexImporter = new BibtexImporter(mock, new DummyFileUpdateMonitor());
70+
Mockito.when(mock.getKeywordSeparator()).thenReturn(',');
71+
modsImporter = new ModsImporter(mock);
7072
}
7173

7274
@Disabled
@@ -78,17 +80,16 @@ public final void testPerformExport(String filename) throws Exception {
7880
Path tempFilename = tempFile.toAbsolutePath();
7981
List<BibEntry> entries = bibtexImporter.importDatabase(importFile, charset).getDatabase().getEntries();
8082
Path xmlFile = Paths.get(ModsExportFormatTestFiles.class.getResource(xmlFileName).toURI());
81-
83+
8284
modsExportFormat.export(databaseContext, tempFile, charset, entries);
8385

8486
Builder control = Input.from(Files.newInputStream(xmlFile));
8587
Builder test = Input.from(Files.newInputStream(tempFilename));
86-
8788
assertThat(test, CompareMatcher.isSimilarTo(control)
8889
.withNodeMatcher(new DefaultNodeMatcher(ElementSelectors.byNameAndText)).throwComparisonFailure());
8990
}
9091

91-
@Disabled
92+
9293
@ParameterizedTest
9394
@MethodSource("fileNames")
9495
public final void testExportAsModsAndThenImportAsMods(String filename) throws Exception {

0 commit comments

Comments
 (0)