Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the programs #43

Closed
ju-sh opened this issue Oct 10, 2019 · 5 comments
Closed

Refactoring the programs #43

ju-sh opened this issue Oct 10, 2019 · 5 comments

Comments

@ju-sh
Copy link
Contributor

ju-sh commented Oct 10, 2019

Can we make the following changes to improve the Python programs?

  • wrap the main code into a function.
  • Using with statements for context management.
  • exception handling

I feel this would make them better and would like to work on this if it's a good idea.

@koppor
Copy link
Member

koppor commented Oct 10, 2019

The are 23 SLOC (https://github.com/JabRef/abbrv.jabref.org/blob/master/update_mathscinet.py) and 32 SLOC (https://github.com/JabRef/abbrv.jabref.org/blob/master/combine_journal_lists.py). They are just little helper tools. Further, they just have been reworked at #41.

The time is better spent on other issues. The user experience of many JabRef users should be improved. Feel free to work on any issue at https://github.com/jabref/jabref/issues.

@koppor koppor closed this as completed Oct 10, 2019
@ju-sh
Copy link
Contributor Author

ju-sh commented Oct 10, 2019

@koppor It would be easy to add tests for if it was made a function or class.

@koppor
Copy link
Member

koppor commented Oct 10, 2019

@ju-sh I know that this is a quick win. TBH: I don't see any user benefit. We have soooo many other issues where users would directly benefit from. There are also quick win issues there: #44

@ju-sh
Copy link
Contributor Author

ju-sh commented Oct 10, 2019

@ju-sh Any issues involving Python?

I understand this is beginner stuff. I just began contributing to others' repos.

Can I suggest other improvements? Like

  • adding argparse so that help will be made available along with scripts. This one will certainly be helpful to the user as the help will show the correct usage of script.

@koppor
Copy link
Member

koppor commented Oct 10, 2019

I think working for https://github.com/sciunto-org/python-bibtexparser/issues makes sense in that case. Especially when seeing JabRef/jabref#5116 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants