Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): support Application<T>(name) #6

Merged
merged 1 commit into from
Sep 5, 2018
Merged

feat(types): support Application<T>(name) #6

merged 1 commit into from
Sep 5, 2018

Conversation

azu
Copy link
Member

@azu azu commented Sep 5, 2018 •
edited
Loading 

import { Application } from "@jxa/types";
import { GoogleChrome } from "./fixtures/GoogleChrome";
// Pass Custom Application type as generics
const chrome = Application<GoogleChrome>("Google Chrome");
const frontWindow: GoogleChrome.Window = chrome.app.windows[0];

fix #5

Todo

  • Update README
    • Welcome to PR :)

@azu azu force-pushed the Application-generics branch from c50b4e4 to 8bec9d4 Compare September 5, 2018 13:06
@azu
feat(types): support Application<T>(name)
d75867a 
```ts
import { Application } from "../src/index";
import { GoogleChrome } from "./fixtures/GoogleChrome";
// Pass Custom Application type as generics
const chrome = Application<GoogleChrome>("Google Chrome");
const frontWindow: GoogleChrome.Window = chrome.app.windows[0];
```
@azu azu force-pushed the Application-generics branch from 8bec9d4 to d75867a Compare September 5, 2018 13:09
@azu azu mentioned this pull request Sep 5, 2018
Closed
@azu azu merged commit fb0d4f9 into master Sep 5, 2018
@azu azu deleted the Application-generics branch September 5, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for non-core applications
1 participant
@azu