Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate entries in completions #92

Closed
hqnna opened this issue May 30, 2024 · 6 comments
Closed

Duplicate entries in completions #92

hqnna opened this issue May 30, 2024 · 6 comments

Comments

@hqnna
Copy link

hqnna commented May 30, 2024

Describe the bug
The language server generates duplicate entries when providing completions.

To Reproduce
Steps to reproduce the behavior:

  1. Install vscode or any other editor with LSP support
  2. Install mesonlsp to the $HOME/.local/bin directory
  3. Ensure $HOME/.local/bin is in your $PATH first
  4. Install the official meson extension and type out the project line
  5. Notice how when typing version you see duplicate entries

Expected behavior
There should only be one entry for each lsp completion item when typing.

Screenshots/Screencasts
image
image

System info

  • OS: macOS Sonoma 14.5
  • Editor: VSCode v1.88.1
  • Version: 4.2.2

Additional context
I was writing an extension for the Zed editor to add lsp and higlighting support for meson, when working on a hobby project with my own extension I noticed duplicates in that editor as well. I thought this might be some code in my extension so I commented out the bit of code used for adding color to suggestions, however even after removing said code and rebuilding the duplicate entry persisted. Given this seems to be persistent across multiple editors, extensions, and environments it seems to be a bug.

It should also be noted the first and second entries act different, with the first one being bugged.

Screen.Recording.2024-05-30.at.01.45.39.mov
@JCWasmx86
Copy link
Owner

JCWasmx86 commented May 30, 2024

Thanks for the bugreport. Weird, because for me it works on VSCode :(

Screencast.from.2024-05-30.13-57-31.webm

image

@JCWasmx86
Copy link
Owner

I will try to setup Zed on Linux and checkout what happens

@JCWasmx86
Copy link
Owner

I think I could reproduce it, even with VSCode

@hqnna
Copy link
Author

hqnna commented May 30, 2024

Completely unsure what's causing this, my extension literally just downloads and runs the language server with the --lsp flag.. This is an extremely odd bug.

@hqnna
Copy link
Author

hqnna commented May 30, 2024

So it appears the duplicate only appears in zed when im typing it on the same line.

Screen.Recording.2024-05-30.at.09.48.36.mov

@JCWasmx86
Copy link
Owner

I think a fix will be there in the next few weeks, as I currently have a lot of other work to do :/ But feel free to investigate it yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants