Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #201 #202

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Fixes #201 #202

merged 2 commits into from
Dec 6, 2019

Conversation

alex-sherwin
Copy link
Contributor

Updated the return type of DEBUGFUNCTION to be 0 instead of void in accordance with the libcurl docs, see https://curl.haxx.se/libcurl/c/CURLOPT_DEBUGFUNCTION.html

Updated the return type of DEBUGFUNCTION
to be 0 instead of void in accordance with the
libcurl docs, see
https://curl.haxx.se/libcurl/c/CURLOPT_DEBUGFUNCTION.html
@JCMais
Copy link
Owner

JCMais commented Dec 6, 2019

@alex-sherwin thanks for the PR.

Your change must be made here:

DEBUGFUNCTION: '((type: number, data: Buffer) => void)',

Those type definitions are automatically generated. You can keep the changes you already made so you don't have to regenerate them, just add it in the options.js file above.

* updated options.js for code-gen of DEBUGFUNCTION type signature
@alex-sherwin
Copy link
Contributor Author

Updated with changes to

DEBUGFUNCTION: '((type: number, data: Buffer) => void)',

I ran the generator, but it updated with a bunch of other things apparently currently missing from the code-generated output, so I discarded everything but the changes relevant to DEBUGFUNCTION

@JCMais
Copy link
Owner

JCMais commented Dec 6, 2019

Yeah, it will retrieve all newer options from libcurl and add them, I will run it later on. Thanks for the PR. I will try to get a patch release this weekend.

@JCMais JCMais merged commit 80d3953 into JCMais:develop Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants