Skip to content

Commit 53743db

Browse files
authored
♻️ Replace email types from str to EmailStr in config.py (fastapi#1492)
1 parent 2a8a962 commit 53743db

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

backend/app/core/config.py

+5-7
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
from pydantic import (
66
AnyUrl,
77
BeforeValidator,
8+
EmailStr,
89
HttpUrl,
910
PostgresDsn,
1011
computed_field,
@@ -74,9 +75,8 @@ def SQLALCHEMY_DATABASE_URI(self) -> PostgresDsn:
7475
SMTP_HOST: str | None = None
7576
SMTP_USER: str | None = None
7677
SMTP_PASSWORD: str | None = None
77-
# TODO: update type to EmailStr when sqlmodel supports it
78-
EMAILS_FROM_EMAIL: str | None = None
79-
EMAILS_FROM_NAME: str | None = None
78+
EMAILS_FROM_EMAIL: EmailStr | None = None
79+
EMAILS_FROM_NAME: EmailStr | None = None
8080

8181
@model_validator(mode="after")
8282
def _set_default_emails_from(self) -> Self:
@@ -91,10 +91,8 @@ def _set_default_emails_from(self) -> Self:
9191
def emails_enabled(self) -> bool:
9292
return bool(self.SMTP_HOST and self.EMAILS_FROM_EMAIL)
9393

94-
# TODO: update type to EmailStr when sqlmodel supports it
95-
EMAIL_TEST_USER: str = "[email protected]"
96-
# TODO: update type to EmailStr when sqlmodel supports it
97-
FIRST_SUPERUSER: str
94+
EMAIL_TEST_USER: EmailStr = "[email protected]"
95+
FIRST_SUPERUSER: EmailStr
9896
FIRST_SUPERUSER_PASSWORD: str
9997

10098
def _check_default_secret(self, var_name: str, value: str | None) -> None:

0 commit comments

Comments
 (0)