Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font families should be mainly select based #163

Open
jorgefilipecosta opened this issue Nov 23, 2020 · 2 comments
Open

Font families should be mainly select based #163

jorgefilipecosta opened this issue Nov 23, 2020 · 2 comments

Comments

@jorgefilipecosta
Copy link
Contributor

The font family control on the typography tools https://g2-components.xyz/iframe.html?id=designtools-presentation-typographypanel--default&viewMode=story should be mainly select based.
The user will be presented with a set of font-family options. The user can choose one of the predefined options. I guess if a value outside of one of the options is passed we may render a text input, but that should not be the default.

@aristath
Copy link

aristath commented Nov 25, 2020

Agreed. It could be a-la-react-select which would accept custom values too, but it should primarily work as a select input 👍

@ItsJonQ
Copy link
Owner

ItsJonQ commented Nov 25, 2020

Sounds like we need a ComboBox :)

That's what react-select is (at least it's primary configuration is a combobox).

We can use downshift, which is what we did for the recently added SelectDropdown (same library used in @wordpress/components).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants