-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corporate account authentication with smart-card #645
Comments
I wonder if you can investigate around maybe checking if this library does the job? https://www.npmjs.com/package/smartcard Hope helps |
I think it would better to use https://www.npmjs.com/package/node-ssl but I could be wrong. To understand how to this works in example in Firefox or Google Chrome you can see https://firefox-source-docs.mozilla.org/security/nss/index.html and documentation for modutil, certutil and etc utilities from nss-tools package. |
@alexey-artyushkov , see if you can integrate it. We will probably need to put it on the back of a config option if it blocks people not using/having smart-cards, but it will be a great addition. I have no means to try/test this, nor much time, so I am unfortunately not much help. |
Thanks a lot) |
I has seen the code and this feature isn't very complex due to this event is handled by browser) |
Open a wee PR and maybe we can see help to get it sorted and released. Thanks a lot! |
@KIX-RTOS if you're not seeing the certification selection dialog in the app but you see in browser, there must be something we can do. Could you provide some screenshots of working and not working scenario. I've never seen such a setup so don't know where to start. |
I realised the why this problem occured - it's not application problem but it's snap's problem. Same issue occurs in Firefox and Chromium if you install them from snaps (https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1859643). In example in Firefox from Snap I can't add smart card module library due to Firefox is sandboxed. But if install Firefox from deb packet this feature works fine). With Teams for Linux I found workaround via SOCKS5 SSH proxy and --proxy-server parameter |
@KIX-RTOS , it will be amazing if you can put some documentation on how you fixed this. Maybe a wee section in the https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/KNOWN_ISSUES.md can help others with this issue. Really appreciate if you can spare a wee bit of time on that. It will help the community lots. Thanks in advance! |
(or even a wee message here with a bit more description on how did you manage, can help a lot of people). I will leave it open for a few more days. Glad to managed to fix it. Thanks again! |
I had a similar need, came up with this PR to fix it: #688 |
left a wee comment (increase the package.json version) but that should be almost ready for release! Thanks for contributing!! |
I will close this issue as completed. Please ask to re-open if the solution @mauriziopinotti doesn't work for you. Thanks a log @mauriziopinotti for your contribution!! https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.0.50 |
But how can I use it now? There is no way to add security devices or something similar to add my smartcard reader. |
I work under Linux and I use Teams to communicate with my colleagues,
authentication goes with smart-card under ADFS domain.
In Google Chrome Teams web-app this feature works fine but teams-for-linux like official client from Microsoft
doesn't show certificate selection dialog and I get an authentication error.
I think the smart-card authentication feature implementation is a good idea.
The text was updated successfully, but these errors were encountered: