Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Tests failing on Drupal 10.2.x; TypeError: trim(): Argument #1 ($string) must be of type string, bool given #1003

Closed
rosiel opened this issue Dec 21, 2023 · 1 comment

Comments

@rosiel
Copy link
Member

rosiel commented Dec 21, 2023

The automated tests are failing on Drupal 10.2.x (which is still unreleased, so it's not critical this passes, but RC1 is out now and release will happen sooner than later).

The error is:

There was 1 error:

1) Drupal\Tests\islandora\FunctionalJavascript\IntegerWeightTest::testIntegerWeightSelector
TypeError: trim(): Argument #1 ($string) must be of type string, bool given

/opt/drupal/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverCurlService.php:120
/opt/drupal/vendor/instaclick/php-webdriver/lib/WebDriver/AbstractWebDriver.php:125
/opt/drupal/vendor/instaclick/php-webdriver/lib/WebDriver/WebDriver.php:66
/opt/drupal/vendor/behat/mink-selenium2-driver/src/Selenium2Driver.php:300
/opt/drupal/vendor/behat/mink/src/Session.php:70
/opt/drupal/vendor/behat/mink/src/Session.php:145
/opt/drupal/web/core/tests/Drupal/Tests/BrowserTestBase.php:281
/opt/drupal/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:88
/opt/drupal/web/core/tests/Drupal/Tests/BrowserTestBase.php:251
/opt/drupal/web/core/tests/Drupal/FunctionalJavascriptTests/WebDriverTestBase.php:54
/opt/drupal/web/core/tests/Drupal/Tests/BrowserTestBase.php:370
/home/runner/work/islandora/islandora/build_dir/tests/src/FunctionalJavascript/IntegerWeightTest.php:84
/opt/drupal/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

I have spent half an hour diving in and can't figure out why it's pointing to IntegerWeightTest's parent::setUp() call, and why trim() doesn't appear except in phpunit's TestCase.php to do with the test's name.

I'm leaving the baton here for now. Feel free to pick it up.

@rosiel rosiel closed this as completed Apr 3, 2024
@rosiel
Copy link
Member Author

rosiel commented Apr 3, 2024

This appears to no longer be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant