Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors #18

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Fix errors #18

merged 3 commits into from
Nov 16, 2022

Conversation

rosiel
Copy link
Contributor

@rosiel rosiel commented Nov 4, 2022

What does this Pull Request do?

Almost nothing! (sorry)

  • resolves an error that gets thrown every time you try to index something
  • updates the languages config.

What's new?

  • index the "Search index" view mode of the "Repository Item" website as fulltext, in order to remove the warning:
    The field Rendered item (rendered_item) on index Default Solr content index is missing view mode configuration for some datasources or bundles. Please review (and re-save) the field settings.

  • I opened and changed nothing and clicked save on the language detection config. It seems they've changed how it was stored since the last time this was done. Therefore this will make future changes clearer.

How should this be tested?

  • Add an object, and see if a "Search API" warning like above shows up
  • Save the language detection config and see if there are any changes to config. (hopefully, there aren't)

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? n/a
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@seth-shaw-asu seth-shaw-asu self-requested a review November 16, 2022 18:42
@seth-shaw-asu seth-shaw-asu merged commit 31dfdd7 into main Nov 16, 2022
@seth-shaw-asu seth-shaw-asu deleted the fix-errors branch November 16, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants