Skip to content

Advanced search block should list/grid view should work without customisation to the theme #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nigelgbanks opened this issue Jul 26, 2021 · 0 comments
Assignees
Labels
Subject: Search related to advanced and basic searching capabilities.

Comments

@nigelgbanks
Copy link
Member

Tricky business to ensure it works without also butting up against customisation in someones theme. At the moment the list / grid toggle changes a css class from view-list to view-grid on the root element of the search view.

The advanced search module does not contain any custom css for this.

So it at the moment it must be added to the theme the user has chosen. This is not ideal, it should work out of the box, but at the same time allow for customisation. Its tricky to get this to play well with custom templates and responsive behaviours given that each site can be wildly different. The base case should only rely on css classes provided by the views module like views-row and not make use of css features that are not widely supported yet.

@nigelgbanks nigelgbanks self-assigned this Jul 26, 2021
@kstapelfeldt kstapelfeldt added Subject: Search related to advanced and basic searching capabilities. and removed bug labels Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subject: Search related to advanced and basic searching capabilities.
Projects
Development

No branches or pull requests

2 participants