-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpaca, API-X and Karaf #13
Conversation
Explicitly i mean
Need to remove probably the fcrepo-* ones because most of that stuff is deployed by API-X (see https://github.com/fcrepo4-labs/fcrepo-api-x/search?utf8=✓&q=org.fcrepo. camel.&type=)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change might be good (Maven settings.xml
comment).
Otherwise, I don't know enough to critique the new Karaf module, but from what I now understand of Ansible, it very much seems like the right thing to do.
|
||
alpaca_karaf_dir: /opt/karaf | ||
alpaca_karaf_etc_dir: "{{ alpaca_karaf_dir }}/etc" | ||
alpaca_local_mvn_path: /home/{{ alpaca_user }}/.m2/repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be a little more Maven-idiomatic to do this with a templated settings.xml
file.
I tried running this and I got the following:
Pretty sure JAVA_HOME is getting set somewhere, but maybe we're not doing it for the Karaf user? |
@dannylamb Perhaps it is related to this issue Islandora/documentation#686, only here we check the return code of all commands, so we see the failures occurring more clearly. Seems like its working for just fine every few builds... |
@jonathangreen same issue (ENV) I had during my humble attempts First i tried setting it via http://docs.ansible.com/ansible/latest/playbooks_environment.html and fetching it back with karaf_home: "{{ lookup('env','KARAF_HOME')| default('/opt/karaf') }}" and no luck (did not seem to stick) |
@DiegoPino I believe |
alpaca_settings: | ||
- pid: ca.islandora.alpaca.connector.broadcast | ||
settings: | ||
input.stream: broker:queue:islandora-connector-broadcast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be activemq:queue:islandora-connector-broadcast
. Anytime you see broker:*
it's just a placeholder for activemq
or whatever other queuing technology camel supports.
@jonathangreen Ha yeah, weird. So looks like if one of the features fails to deploy, we get the JAVA_HOME warning even though that's not the actual reason for the failure. I pushed through with a retry and found a few config values that need to be set. The Api-X proxy endpoint wasn't available either, but that may be because of those missing values. I'm not sure. |
@jonathangreen I'm giving this another whirl now that Islandora/documentation#686 has landed. |
- pid: org.fcrepo.apix.registry.http | ||
settings: | ||
timeout.socket.ms: 1000 | ||
- pid: org.fcrepo.camel.indexing.triplestore.cfg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for some reason, this is creating a second config file with an extra .cfg
at the end: org.fcrepo.camel.indexing.triplestore.cfg.cfg
. If we can sort this out, we're good to go. All other functionality is there. The proxy is up and Fedora + 3store sync'ing is happening from Drupal, just this last bit is preventing the 3store indexer from Fedora..
- name: Template settings | ||
template: | ||
src: apix.cfg.j2 | ||
dest: "{{ apix_karaf_etc_dir }}/{{ item.pid }}.cfg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see. It's here. Either drop the .cfg's in the pids or drop it here and put them all the pid entries at roles/internal/apix/defaults/main.yml
…crease_upload_size Increase upload limits
Issue
This is an extension of the work done by @DiegoPino here:
#8
Resolves:
Islandora/documentation#692
Information
This PR updates the Karaf role to add two new Ansible modules for manipulating Karaf repos and Karaf features. I am usually fairly opposed to adding new modules, since they increase complexity, you both have to understand the playbook and the python code, but I was having a lot of trouble creating tasks to add karaf repos and features in a nice idempotent way, so I went the module route. I think they will come in handy as we do more work with Karaf.
This PR then adds two new roles, API-X and Alpaca that leverage these new modules to setup API-X and Alpaca in Karaf.
Testing
Bring up vagrant with claw playbook and make sure that:
Interested parties
@DiegoPino @whikloj @ajs6f @dannylamb