Headers passthru #64
Merged
Headers passthru #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 93.45% 93.63% +0.17%
==========================================
Files 3 3
Lines 107 110 +3
==========================================
+ Hits 100 103 +3
Misses 7 7
Continue to review full report at Codecov.
|
|
Tested and works! <?php
require __DIR__ . '/chullo/vendor/autoload.php';
use Islandora\Chullo\FedoraApi;
$chullo = FedoraApi::create("http://localhost:8080/fcrepo/rest");
try {
$uri = $chullo->saveResource("not_the_full_uri", "", ['Authorization' => "Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.eyJpYXQiOjE0OTIwMjIwNDAsImV4cCI6MTQ5MjAyOTI0MCwidWlkIjoiMSIsIm5hbWUiOiJhZG1pbiIsInJvbGVzIjpbImF1dGhlbnRpY2F0ZWQiLCJhZG1pbmlzdHJhdG9yIl0sInVybCI6Imh0dHBzOlwvXC9sb2NhbGhvc3Q6ODAwMCJ9.aCZ-CkdUlNyBmXjU9snP2gGuzYCaFO694sJQ81UE-tSslyS8TuEakD58JEpOY58b2aM-JkX3E8wYJXeVNY2WN8BAOkHnqrYzUe324jYy9wjiiCj5nsB_YJeh7Un0nSRom-FbZ42sQQekVoUu4nxVxisj00mSWbSDxusN-0dt0jazUjBkncdhj3hoABUZ14hCFJzdYmUVyoDoqybLJM1kxiH4OD1iBpZV8NXeCI3XfXi8HowZdZO1CMoMDLEQB9aRVpG5E1ntmc-FChb5rsNRomJ3d71iascq8JKFFC4M_WByPKt5705l4S5i-RFqnbuXFfLaFV5N3DwfRDaEDk60Vg"]);
echo $uri->getStatusCode();
echo "\n";
echo $uri->getBody();
echo "\n";
} catch (Exception $e) {
echo 'Caught exception: ', $e->getMessage(), "\n";
}
?>Without PR applied: With PR applied: |
ruebot
approved these changes
Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: part of Islandora/documentation#597
What does this Pull Request do?
Adds parameters to functions in IFedoraApi and its implementations so that we can pass authorization tokens through to Fedora. I ran into this when trying to issue a HEAD request to get an ETag.
What's new?
The interface changes above. I also ran into a funky issue with how Guzzle clients handle their base uri, so I added some sanitization around that so no one else wastes an hour next time they don't add the trailing slash to their fedora base url.
How should this be tested?
Before this PR, give Chullo a base url of
http://localhost:8080/fcrepo/restand issue a PUT request tohttp://localhost:8080/fcrepo/rest/foo. You should get denied with a 403.Pull in this PR and do the same. You should get a successful response and be able to visit the created resource.
You can then also issue HEAD, OPTION, and DELETE requests passing in your JWT as the 'Authorization' header with a FedoraApi class. Analogous functions in Chullo have also been updated, so you can try those out too.
Interested parties
@Islandora-CLAW/committers