Address https://github.com/Islandora-CLAW/CLAW/issues/302 ; Query Par…

[ruebot]

…ameters: CHECKSUM (Optional - DEPRECATED)

See: Islandora/documentation#302

[whikloj]

So this changes how the checksum is formatted. We used to just pass a checksum, but now that checksum is actually "<checksum type>=<checksum>".

For example, in the Chullo README there is an example of

$child_uri = $chullo->createResource(
        $uri,
        $rdf,
        ['Content-Type' => 'text/turtle'],
        $transaction,
        sha1($rdf)
    );

That now fails due to the change in Fedora, but using this change also doesn't work.

We need to change it to specify the checksum type as well as the checksum.

Like

$child_uri = $chullo->createResource(
        $uri,
        $rdf,
        ['Content-Type' => 'text/turtle'],
        $transaction,
        "sha1=" . sha1($rdf)
    );

So the code is fine, but the argument is changing.

I just want to make sure that we are okay with this, or should we separate the information out into two arguments or an array of arguments? <shrug>

[ruebot]

I just want to make sure that we are okay with this, or should we separate the information out into two arguments or an array of arguments?

We'll, since fcrepo4 really only supports one fixity type right now, I'm fine with leaving it like that. Once we get more, then we can add more.

...but...hrm...what about migrating fcrepo3 fixity information?

[whikloj]

I haven't tried (but I will) using a "md5=blah" checksum

[whikloj]

Ok, so md5 seems to be disregarded.
I did
$new_image = $api->createResource("", $image_content, $headers, "", 'md5=823478435');
and it created the resource but
$new_image = $api->createResource("", $image_content, $headers, "", 'sha1=823478435');
gave a 409 Conflict response.
FYI, I made up the checksum.

[ruebot]

@whikloj should we change it from a string to an array? Or have two string values, checksum_algorithm and checksum_value?

[ruebot]

@whikloj if that's the route we want to go, I can work on updating the test where it failed.

[codecov-io]

Current coverage is 86.48% (diff: 100%)

Merging #51 into master will increase coverage by 0.58%

@@             master        #51   diff @@
==========================================
  Files             4          4          
  Lines           227        222     -5   
  Methods          36         36          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            195        192     -3   
+ Misses           32         30     -2   
  Partials          0          0          

Powered by Codecov. Last update 1593cae...9abaa57

[whikloj]

You don't need this line.

[DiegoPino]

@ruebot that last one looks fine. $headers is the way, less arguments, closer to fcrepo REST API 👍

[ruebot]

@whikloj @DiegoPino I still need to update Crayfish and PDX, and then this issue should be resolved.

[ruebot]

Islandora/Crayfish#12

[ruebot]

Nothing in PDX according to grep.

[whikloj]

Error in test is because you need to define the base_uri on the Client here. Check the other test.