Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to cancel in-progress compression #49

Closed
imathrowback opened this issue Oct 16, 2017 · 4 comments
Closed

Add ability to cancel in-progress compression #49

imathrowback opened this issue Oct 16, 2017 · 4 comments

Comments

@imathrowback
Copy link

Add a cancel button to cancel in progress compression without leaving behind processes.

If the window is closed while a compression is running, the compression child process is left running.

image

@NoFunk
Copy link

NoFunk commented Oct 16, 2017

Can confirm, ran 5 compressions then closed them all, the processes are still open in the background.

@Iridium-IO
Copy link
Member

There's an issue with this - I can't get the background process to gracefully shut down when it's called from within CompactGUI (WTF Microsoft).

For now what I've done is added a check: If an active compression/decompression is running and you try to exit, it will show you a warning telling you that proceeding with closure is potentially dangerous. If you then decide to continue, it will forcefully kill the process, potentially leaving a semi-compressed file behind.
You can repair this semi-compressed file by letting the program run with the Force compression/uncompression option selected, then either select "Compress Folder" or "Uncompress Folder"

@imathrowback
Copy link
Author

imathrowback commented Oct 17, 2017

A reason to have a cancel option is when you go to compress a directory full of gigabyte files (eg, game resources) and and if they don't' compress well, you don't want to continue compression as you will get nothing out of it and it'll take ages to complete.

An alternative fix might be to call compact.exe per file rather than using the /s command.

@Iridium-IO
Copy link
Member

Iridium-IO commented Oct 17, 2017

Yeah I'm looking into that as an alternative, but I don't like the idea of taking more control away from the Windows command. I'd prefer to leave as much as possible up to Windows to do, since this is meant to be a visual interface - nothing much more.

Right now if you look at the wiki you can see which games compress well and which don't, which should help with avoiding most of the big ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants