Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some placeholders have no output + add rounded placeholders or output rounded values #832

Open
RaptorXilef opened this issue Apr 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working confirmed A verified issue that is worked on medium

Comments

@RaptorXilef
Copy link

RaptorXilef commented Apr 5, 2024

Describe the Bug and Feature Request

  1. There are several placeholders in IridiumSkyblock. Some of them have an output if you want to use them in other plugins. For example, if we insert them into our scoreboard plugin. However, other placeholders work wonderfully.

Placeholder without output:

  • %iridiumskyblock_island_rank%
  • %iridiumskyblock_island_experience_required%
  • %iridiumskyblock_island_experience_remaining%
  • %iridiumskyblock_island_overworld_biome%
  • %iridiumskyblock_island_nether_biome%
  • %iridiumskyblock_island_end_biome%
  • %iridiumskyblock_island_upgrade_member_amount%
  • %iridiumskyblock_island_upgrade_warp_amount%
  • %iridiumskyblock_island_upgrade_size_dimensions%
  • %iridiumskyblock_island_members%
  • %iridiumskyblock_island_visitors%
  • %iridiumskyblock_island_players%
  • %iridiumskyblock_island_member_names%
  • %iridiumskyblock_island_visitor_names%
  • %iridiumskyblock_island_player_names%

Working placeholders:

  • %iridiumskyblock_island_name%'
  • %iridiumskyblock_island_owner%
  • %iridiumskyblock_island_bank_money%
  • %iridiumskyblock_island_bank_experience%
  • %iridiumskyblock_island_bank_crystals%
  • %iridiumskyblock_island_level%
  • %iridiumskyblock_island_experience%
  • %iridiumskyblock_island_value%

Expected behavior
An output of a string or a value.




  1. If we use two specific placeholders, these are displayed with far too many decimal places, which has a negative impact on clarity. See screenshots.
  • %iridiumskyblock_island_bank_money% -> is: 22018.916400000002 -> expected: 22018.91
  • %iridiumskyblock_island_value% -> is: 272.40000000000003 -> expected: 272.4

The unexpected expenditure at %iridiumskyblock_island_bank_money% only occurs when a player deposits all his money into the bank. If only full amounts are deposited, the value is displayed correctly. I suspect that in this case Vault passes a value with more than 12 decimal places to IridiumSkyblock, so that it automatically continues to work with this value. Perhaps a solution could be found at this point.
The unexpected output at %iridiumskyblock_island_value% always occurs.

Expected behavior
The output of a value rounded to max. 2 decimal places.

Wish
Can you limit the output of these variables/placeholders to two decimal places or insert two additional placeholders that also output the rounded values?

Server and Plugin Version
/version

Previous version: git-Paper-461 (MC: 1.20.4)

/is about

- Plugin Name: IridiumSkyblock
- Plugin Version: 4.0.9
- Plugin Author: Peaches_MLG

Screenshots
2024,04,05-18,58,47-001 __________ 2024,04,05-19,01,08-001

Should you require further information from me, please do not hesitate to contact me at any time.

@RaptorXilef RaptorXilef added bug Something isn't working unconfirmed An issue that needs further investigation labels Apr 5, 2024
@sh0inx
Copy link
Contributor

sh0inx commented Apr 6, 2024

does this also happen when setting the number formatter in settings?

configuration.yml

numberFormatter:
  numberAbbreviationDecimalPlaces: 2

@RaptorXilef
Copy link
Author

RaptorXilef commented Apr 6, 2024

Yes, I have set the settings as you described. The BUG described above in the display of decimal places still exists.
Even changing the value to 1 or 0 does not change anything.
My current attitude is:

configuration.yml

numberFormatter:
  numberAbbreviationDecimalPlaces: 2
  thousandAbbreviation: "K"
  millionAbbreviation: "M"
  billionAbbreviation: "B"
  trillionAbbreviation: "T"
  displayNumberAbbreviations: true

As a test, I used the placeholders in another plugin, "DecentHolograms", to check whether the incorrect output was due to the scoreboard plugin.
Unfortunately, "DecentHolograms" displays the values with the same result.

2024,04,06-15,15,15-001

@dlsf dlsf added confirmed A verified issue that is worked on and removed unconfirmed An issue that needs further investigation labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed A verified issue that is worked on medium
Projects
None yet
Development

No branches or pull requests

5 participants