Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#2724): move drep list pagination directly to sql #2865

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(#2724): move drep list pagination directly to sql #2865

wants to merge 1 commit into from
+488 −326

Conversation

MSzalowski
Copy link
Contributor

@MSzalowski MSzalowski commented Jan 31, 2025 •
edited
Loading

List of changes

  • Move pagination directly to sql
  • Move logic of differentiation between DRep and SoleVoter into SQL
  • Move sorting and filtering directly to SQL
  • Add common types for DRep
  • Add logs to query and request execution

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Jan 31, 2025 that may be closed by this pull request
💡 Move drep-list pagination directly to sql #2724
Open
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the feat/2724-move-drep-list-pagination-directly-to-sql branch from 3cae62b to 2ee0f6f Compare February 4, 2025 07:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the feat/2724-move-drep-list-pagination-directly-to-sql branch from 2ee0f6f to dbac517 Compare February 4, 2025 08:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the feat/2724-move-drep-list-pagination-directly-to-sql branch from dbac517 to 67f80a0 Compare February 4, 2025 10:26
@MSzalowski MSzalowski changed the title Feat/2724 move drep list pagination directly to sql feat(#2724): move drep list pagination directly to sql Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the feat/2724-move-drep-list-pagination-directly-to-sql branch from 67f80a0 to a145401 Compare February 4, 2025 10:29
@MSzalowski MSzalowski marked this pull request as ready for review February 4, 2025 10:29
@MSzalowski MSzalowski requested a review from Ryun1 as a code owner February 4, 2025 10:29
@MSzalowski MSzalowski requested a review from placek February 4, 2025 10:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

placek
placek approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@placek placek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Great job!

govtool/backend/app/Main.hs
@@ -144,6 +144,7 @@ startApp vvaConfig sentryService = do

exceptionHandler :: VVAConfig -> SentryService -> Maybe Request -> SomeException -> IO ()
exceptionHandler vvaConfig sentryService mRequest exception = do
print exception
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in the end it is useful, isn't it?

@MSzalowski MSzalowski force-pushed the feat/2724-move-drep-list-pagination-directly-to-sql branch from a145401 to d6c56f5 Compare February 4, 2025 14:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

✅ All checks succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💡 Move drep-list pagination directly to sql
2 participants
@MSzalowski @placek