-
Notifications
You must be signed in to change notification settings - Fork 166
Stop using UMap in favor of Accounts type family
#5128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0fa485d to
ca95503
Compare
teodanciu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first pass, will have another look later! Looks great, I finally feel I can be friends with DState 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor corrections
teodanciu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few more minor suggestions
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/PulsingReward.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Rules/Deposits.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Examples/Combinators.hs
Show resolved
Hide resolved
teodanciu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That a huge piece of work!! I think it's a great improvement in terms of understanding not only what we store/map but also how to work with it, thanks to the clear interface.
I admit I got lost with the Transition modules, I don't understand at all what they're about, but that's on me, I shall study them.
Looks good to me, great work!
6c37635 to
afaa57f
Compare
f802c1e to
5eeb3a8
Compare
0587e7f to
c45599a
Compare
0eaa472 to
1d65cea
Compare
1d65cea to
b572293
Compare
08d299b to
511bf0e
Compare
59db22c to
cf64cb7
Compare
cf64cb7 to
91337ed
Compare
7fe644a to
aebc670
Compare
dad8b64 to
c8fd673
Compare
Introduce two type families for `Accounts` and `AccountState` that have different representation for Conway era and era before it
c8fd673 to
a40f047
Compare
Description
Resolves #4694
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).