Skip to content

Conversation

@lehins
Copy link
Collaborator

@lehins lehins commented Jun 18, 2025

Description

Resolves #4694

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@lehins lehins mentioned this pull request Jun 18, 2025
23 tasks
@lehins lehins force-pushed the lehins/era-specific-umap branch from 0fa485d to ca95503 Compare June 24, 2025 21:11
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first pass, will have another look later! Looks great, I finally feel I can be friends with DState 😆

Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor corrections

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few more minor suggestions

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That a huge piece of work!! I think it's a great improvement in terms of understanding not only what we store/map but also how to work with it, thanks to the clear interface.

I admit I got lost with the Transition modules, I don't understand at all what they're about, but that's on me, I shall study them.

Looks good to me, great work!

@lehins lehins force-pushed the lehins/era-specific-umap branch 3 times, most recently from 6c37635 to afaa57f Compare June 28, 2025 02:05
@TimSheard TimSheard force-pushed the lehins/era-specific-umap branch 3 times, most recently from f802c1e to 5eeb3a8 Compare July 2, 2025 12:16
@lehins lehins force-pushed the lehins/era-specific-umap branch from 0587e7f to c45599a Compare July 3, 2025 06:01
@TimSheard TimSheard force-pushed the lehins/era-specific-umap branch 4 times, most recently from 0eaa472 to 1d65cea Compare July 8, 2025 14:07
@lehins lehins force-pushed the lehins/era-specific-umap branch from 1d65cea to b572293 Compare July 10, 2025 18:36
@TimSheard TimSheard force-pushed the lehins/era-specific-umap branch 2 times, most recently from 08d299b to 511bf0e Compare July 15, 2025 19:17
@lehins lehins force-pushed the lehins/era-specific-umap branch 6 times, most recently from 59db22c to cf64cb7 Compare July 18, 2025 01:07
@lehins lehins force-pushed the lehins/era-specific-umap branch from cf64cb7 to 91337ed Compare July 18, 2025 18:00
@lehins lehins force-pushed the lehins/era-specific-umap branch 2 times, most recently from 7fe644a to aebc670 Compare July 18, 2025 20:45
@lehins lehins marked this pull request as ready for review July 18, 2025 21:09
@lehins lehins requested a review from a team as a code owner July 18, 2025 21:09
@lehins lehins force-pushed the lehins/era-specific-umap branch 2 times, most recently from dad8b64 to c8fd673 Compare July 18, 2025 21:28
@lehins lehins force-pushed the lehins/era-specific-umap branch from c8fd673 to a40f047 Compare July 18, 2025 22:26
@lehins lehins enabled auto-merge July 18, 2025 22:28
@lehins lehins merged commit ee4feea into master Jul 19, 2025
128 checks passed
@lehins lehins deleted the lehins/era-specific-umap branch July 19, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace UMap with a better tailored representation and name

4 participants